Add SbmlModel.{to_antimony,to_sbml_str}#371
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #371 +/- ##
========================================
Coverage 74.58% 74.59%
========================================
Files 58 58
Lines 6123 6133 +10
Branches 1061 1062 +1
========================================
+ Hits 4567 4575 +8
- Misses 1149 1150 +1
- Partials 407 408 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Simplify conversion of SBML models to antimony and XML stirngs. Convenient in particular for debugging.
dilpath
left a comment
There was a problem hiding this comment.
Looks fine to me. Should Model have to_str and from_str methods such that Problem.model_dump can serialize the model, too?
|
Can the functions be |
Agreed, and this is the current state in this PR too. My comment was rather about (de)serialization of SBML and antimony models, not interconversion. Since the But this (de)serialization to string is not important to me -- just that it would make the pydantic |
It could be convenient at times, but I don't see a strong need yet. At least, I wouldn't require its implementation for every model type. |
Simplify conversion of SBML models to antimony and XML strings. Convenient in particular for debugging.