Handle observableTransformation in petab.v1.simulate.sample_noise#383
Merged
dweindl merged 4 commits intoPEtab-dev:developfrom Apr 28, 2025
Merged
Handle observableTransformation in petab.v1.simulate.sample_noise#383dweindl merged 4 commits intoPEtab-dev:developfrom
observableTransformation in petab.v1.simulate.sample_noise#383dweindl merged 4 commits intoPEtab-dev:developfrom
Conversation
Previously, `petab.v1.simulate.sample_noise` silently ignored `observableTransformation`. For example, in case of observableTransformation=log and noiseDistribution=normal, it incorrectly sampled from a normal instead of a log-normal distribution. Fixes PEtab-dev#382.
Member
Author
|
Test failures are unrelated and fixed in #381. |
dilpath
approved these changes
Apr 28, 2025
Member
dilpath
left a comment
dilpath
left a comment
There was a problem hiding this comment.
Thanks for reporting and fixing, @PaulJonasJost and @dweindl
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
PaulJonasJost
approved these changes
Apr 28, 2025
Collaborator
PaulJonasJost
left a comment
PaulJonasJost
left a comment
There was a problem hiding this comment.
Thanks for this 🙏🏼
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #383 +/- ##
===========================================
- Coverage 74.05% 74.00% -0.06%
===========================================
Files 58 58
Lines 6460 6470 +10
Branches 1113 1115 +2
===========================================
+ Hits 4784 4788 +4
- Misses 1256 1260 +4
- Partials 420 422 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
petab.v1.simulate.sample_noisesilently ignoredobservableTransformation. For example, in case of observableTransformation=log and noiseDistribution=normal, it incorrectly sampled from a normal instead of a log-normal distribution.Fixes #382.