Merged
Conversation
dilpath
approved these changes
Feb 4, 2026
Member
dilpath
left a comment
dilpath
left a comment
There was a problem hiding this comment.
Thanks! Left some semi-related comments that don't need to be addressed in this PR.
Comment on lines
+246
to
249
| hybridization table, etc.). For :ref:`simulation | ||
| hybridization <hybrid_types>`, input PEtab identifiers can only | ||
| be assigned an expression in the :ref:`hybridization | ||
| table <hybrid_table>`. |
Member
There was a problem hiding this comment.
The spec currently states that inputs have their own e.g. user-specified names, e.g. the input variable name in the pytorch module that is then converted to the NN model YAML format.
- These are valid IDs for the array file. Are they also valid IDs for the hybridization table, or do they need to be mapped onto new IDs via the mapping table?
- Can input IDs defined in the mapping table, be used in the array files?
Collaborator
Author
There was a problem hiding this comment.
I think most of the things here will be clarified with the PR that will introduce explicit array assignments, but lets keep these points in mind.
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
BSnelling
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49
In brief, updates to use pre-initialization and simulation-initialization.