Fix build #260
Merged
Fix build #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis update introduces Firebase Cloud Messaging integration, dynamic form management, and beneficiary consent OTP handling. It adds new configuration properties, controller classes, DTOs, entities, repositories, and services for these features. The JWT utility is refactored, and new endpoints for notification and form management are provided. Minor logging and configuration improvements are also included. Changes
Sequence Diagram(s)Beneficiary Consent OTP FlowsequenceDiagram
participant Client
participant BeneficiaryConsentController
participant BeneficiaryOTPHandlerImpl
participant ExternalSMSService
Client->>BeneficiaryConsentController: POST /beneficiaryConsent/sendConsent (mobNo)
BeneficiaryConsentController->>BeneficiaryOTPHandlerImpl: sendOTP(request)
BeneficiaryOTPHandlerImpl->>BeneficiaryOTPHandlerImpl: generateOTP()
BeneficiaryOTPHandlerImpl->>ExternalSMSService: sendSMS(otp, mobNo)
ExternalSMSService-->>BeneficiaryOTPHandlerImpl: SMS sent response
BeneficiaryOTPHandlerImpl-->>BeneficiaryConsentController: Success/Failure
BeneficiaryConsentController-->>Client: OutputResponse (success/error)
Firebase Notification FlowsequenceDiagram
participant Client
participant FirebaseNotificationController
participant FirebaseNotificationService
participant FirebaseMessaging
Client->>FirebaseNotificationController: POST /firebaseNotification/sendNotification (NotificationMessage)
FirebaseNotificationController->>FirebaseNotificationService: sendNotification(notificationMessage)
FirebaseNotificationService->>FirebaseMessaging: send(message)
FirebaseMessaging-->>FirebaseNotificationService: response
FirebaseNotificationService-->>FirebaseNotificationController: response string
FirebaseNotificationController-->>Client: response
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (35)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # DB Connections | ||
| spring.datasource.url=jdbc:mysql://localhost:3306/db_iemr | ||
| spring.datasource.username=<Enter password> | ||
| spring.datasource.password=YesBank@123# |
Check failure
Code scanning / SonarCloud
Database passwords should not be disclosed High
| # DB Connections | ||
| spring.datasource.url=jdbc:mysql://localhost:3306/db_iemr | ||
| spring.datasource.username=<Enter password> | ||
| spring.datasource.password=YesBank@123# |
Check failure
Code scanning / SonarCloud
Credentials should not be hard-coded High
| spring.datasource.driver-class-name=com.mysql.jdbc.Driver | ||
|
|
||
| secondary.datasource.username=<Enter username> | ||
| secondary.datasource.password=<Enter password> |
Check failure
Code scanning / SonarCloud
Database passwords should not be disclosed High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Description
JIRA ID:
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit
New Features
Configuration
Improvements
Bug Fixes
Chores