🩹 [Patch]: Refactor Update-FontsData.ps1#44
Merged
Marius Storhaug (MariusStorhaug) merged 5 commits intomainfrom Jul 22, 2025
Merged
🩹 [Patch]: Refactor Update-FontsData.ps1#44Marius Storhaug (MariusStorhaug) merged 5 commits intomainfrom
Marius Storhaug (MariusStorhaug) merged 5 commits intomainfrom
Conversation
…n Update-FontsData.ps1
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the Update-FontsData.ps1 script by replacing Invoke-NativeCommand with a Run alias and simplifying the parameter handling approach. The refactor improves code readability while maintaining the same core functionality for updating font data.
Key changes include:
- Replaced
Invoke-NativeCommandfunction calls withRunalias throughout the script - Simplified parameter structure by using a single array parameter with array slicing
- Improved change detection logic by inverting the condition for early exit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the
Update-FontsData.ps1script to improve readability, simplify command execution, and enhance functionality. The most significant changes include replacingInvoke-NativeCommandwith theRunalias, restructuring the command execution logic, and refining the behavior for detecting and committing changes.Command Execution Refactor
Invoke-NativeCommandwith theRunalias. This change affects all Git-related operations, such as fetching, checking out branches, merging, and pushing changes.$Commandargument to treat the first element as the command and subsequent elements as arguments, simplifying the way commands are constructed and executed.Improved Change Detection and Commit Workflow
Minor Adjustments
auto-font-update-$timeStamptoauto-update-font-$timeStamp).Type of change
Checklist