-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[AutoParallel] Refactor llama3.1 model in intermediate api #3116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution! |
8d6ca3a to
88963b1
Compare
7b15fd1 to
9524073
Compare
|
/re-run all-failed |
9524073 to
05b7388
Compare
liym27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| query_states = self.q_proj(hidden_states).view(q_shape).transpose(1, 2) | ||
| key_states = self.k_proj(hidden_states).view(kv_shape).transpose(1, 2) | ||
| value_states = self.v_proj(hidden_states).view(kv_shape).transpose(1, 2) | ||
| query_states = self.q_proj(hidden_states).reshape(q_shape).transpose(1, 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么要改为reshape?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么要改为reshape?
paddle transpose的问题,这里view之后虽然变成四维的,但是transpose还是认为该tensor是三维,即view之前的维度
| "down_proj", | ||
| ] | ||
|
|
||
| @classmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个name_mapping的作用?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个name_mapping的作用?
这个确实没什么用,现在版本里一些其他的模型还留着 ,所以没有删除
lugimzzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
rename run_single_model to use_single_model_implementation
remove redundant notes
based on #2859