Skip to content

Conversation

@sevenan2
Copy link
Contributor

@sevenan2 sevenan2 commented Dec 5, 2025

rename run_single_model to use_single_model_implementation
remove redundant notes
based on #2859

@paddle-bot
Copy link

paddle-bot bot commented Dec 5, 2025

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2025

CLA assistant check
All committers have signed the CLA.

@sevenan2 sevenan2 marked this pull request as draft December 8, 2025 04:00
@sevenan2 sevenan2 marked this pull request as ready for review December 8, 2025 04:00
@sevenan2 sevenan2 force-pushed the refactor_model_2 branch 3 times, most recently from 7b15fd1 to 9524073 Compare December 10, 2025 06:18
@sevenan2
Copy link
Contributor Author

/re-run all-failed

Copy link

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

query_states = self.q_proj(hidden_states).view(q_shape).transpose(1, 2)
key_states = self.k_proj(hidden_states).view(kv_shape).transpose(1, 2)
value_states = self.v_proj(hidden_states).view(kv_shape).transpose(1, 2)
query_states = self.q_proj(hidden_states).reshape(q_shape).transpose(1, 2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要改为reshape?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要改为reshape?

paddle transpose的问题,这里view之后虽然变成四维的,但是transpose还是认为该tensor是三维,即view之前的维度

"down_proj",
]

@classmethod
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个name_mapping的作用?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个name_mapping的作用?

这个确实没什么用,现在版本里一些其他的模型还留着 ,所以没有删除

Copy link
Collaborator

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lugimzzz lugimzzz merged commit aac30fd into PaddlePaddle:develop Dec 10, 2025
5 checks passed
@sevenan2 sevenan2 mentioned this pull request Dec 11, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants