fix: handle allOf with incompatible types#1308
Merged
sserrata merged 1 commit intoPaloAltoNetworks:mainfrom Feb 17, 2026
Merged
fix: handle allOf with incompatible types#1308sserrata merged 1 commit intoPaloAltoNetworks:mainfrom
sserrata merged 1 commit intoPaloAltoNetworks:mainfrom
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
|
Visit the preview URL for this PR (updated for commit 3ec416b): https://docusaurus-openapi-36b86--pr1308-zzh2tsab.web.app (expires Thu, 19 Mar 2026 19:30:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bf293780ee827f578864d92193b8c2866acd459f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an allOf contains sub-schemas with incompatible primitive types (e.g. string + integer), the
allof-mergelibrary returnsundefined. The code then tries to access.readOnlyon that and craches. Fixed by falling back to an empty object{}in both the plugin and thememergeAllOfwrappers. All call sites already handle empty objects fine.Motivation and Context
Pages with these kinds of allOf schemas crash on load. This comes up when an API spec overrides a property type through allOf composition, like changing an integer field to a string enum.
Fixes #1231
How Has This Been Tested?
sampleFromSchemawith incompatible allOf (top-level and inside a property)demo/examples/tests/allOf.yamlScreenshots (if appropriate)
N/A
Types of changes
Checklist