Add and clarify Attribute#getDefaultValue #13345
Open
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malfrador
approved these changes
Nov 24, 2025
Member
Malfrador
left a comment
Malfrador
left a comment
There was a problem hiding this comment.
Not sure the deprecation is entirely necessary but overall lgtm.
Maybe exposing the min/max value would be cool in the future, but thats probably better for a separate PR. Surprised to learn that isn't API already.
Member
|
I think it is a point of confusion leaving it there because the default isn't tied to the attribute instance but to the attribute itself, having it there is just misleading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13343