Fix NPE when unsetting leash holder in EntityUnleashEvent#13648
Open
datatags wants to merge 1 commit intoPaperMC:mainfrom
Open
Fix NPE when unsetting leash holder in EntityUnleashEvent#13648datatags wants to merge 1 commit intoPaperMC:mainfrom
datatags wants to merge 1 commit intoPaperMC:mainfrom
Conversation
Member
|
This now ignore the dropLeash set when unset? |
datatags
force-pushed
the
fix-leash-holder-npe
branch
from
58fdc7d to
df9684c
Compare
Author
|
Oops, didn't mean to move that line, fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #13645, where a NPE may result if a plugin unsets the leash holder of the entity in question during the
EntityUnleashEvent. This is resolved by simply checking if theleashHolderis null before attempting to play the sound.