Skip to content

🛡️ Sentinel: Fix path traversal in job filename #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GhostTypes merged 1 commit into from
Jan 24, 2026
Merged

🛡️ Sentinel: Fix path traversal in job filename #35

GhostTypes merged 1 commit into from
Jan 24, 2026

Conversation

@google-labs-jules
Copy link

@google-labs-jules google-labs-jules bot commented Jan 22, 2026

  • Updated JobStartRequestSchema in src/main/webui/schemas/web-api.schemas.ts to reject .. segments.
  • Updated JobStartDataSchema in src/main/webui/schemas/web-api.schemas.ts similarly.
  • Added test case src/main/webui/schemas/__tests__/web-api.schemas.test.ts.

PR created automatically by Jules for task 10888890562247032828 started by @GhostTypes

@google-labs-jules
🛡️ Sentinel: [CRITICAL] Fix path traversal in job filename
3d51c6e 
🚨 Severity: CRITICAL
💡 Vulnerability: The `startJob` API endpoint allowed filenames with path traversal characters (e.g., `../../etc/passwd`), potentially exposing the file system.
🎯 Impact: Attackers could potentially read or manipulate arbitrary files on the system if the printer backend logic allows it.
🔧 Fix: Added Zod schema refinement to `JobStartRequestSchema` and `JobStartDataSchema` to strictly reject filenames containing `..` path segments.
✅ Verification: Added `src/main/webui/schemas/__tests__/web-api.schemas.test.ts` to verify that `..` patterns are rejected while valid filenames are accepted. Verified using a standalone script.
@google-labs-jules
Copy link
Author

google-labs-jules bot commented Jan 22, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@GhostTypes GhostTypes marked this pull request as ready for review January 24, 2026 19:29
@GhostTypes GhostTypes merged commit f02017f into alpha Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GhostTypes