-
Notifications
You must be signed in to change notification settings - Fork 48
Update to NServiceBus.RabbitMQ 10.0.0 and use management client #4755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonsmits
reviewed
Jan 31, 2025
b0161f3 to
f41444c
Compare
360900d to
7131ce0
Compare
414b7a5 to
6ca6c1d
Compare
* Migrate RabbitMQ management API settings from separate app.config entries into the connection string * Renamed settings related to Licensing component's use of RabbitMQ management API Removed unnecessary LINQ usage when working with DbConnectionStringBuilder in ServiceControlAppConfig
a9ae9c6 to
c1e1622
Compare
bording
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades the RabbitMQ transport to version 10.
The new transport version brings a new requirement for ServiceControl to operate: The RabbitMQ management plugin must be enabled, and the plugin's statistics and metrics collection must not be disabled.
By default, the settings to access the API will be inferred from the connection string, but the following new connection string settings have been added if custom values are needed:
ManagementApiUrlManagementApiUserNameManagementApiPasswordThe transport also does delivery limit validation by default, but that can be controlled with the new
ValidateDeliveryLimitsconnection string setting.Other changes in this PR:
RabbitMQQueryandQueueLengthProviderclasses now access the management API through the transport's management client instead of having their own custom logic.ManagementClientinstance that the transport creates during initialization.DisableRemoteCertificateValidationandUseExternalAuthMechanismare once again working properly instead of being ignored.Related Documentation: