Skip to content

Conversation

@ramonsmits
Copy link
Member

@ramonsmits ramonsmits commented Feb 6, 2025

When ingestion hangs and the service looks unresponse a user might want to stop the instance. Especially for the batch ingestion is makes sense to support cancellation as this is a long running operations.

This is a port and continuation of my investigation PR:

@ramonsmits ramonsmits self-assigned this Feb 6, 2025
@ramonsmits
Copy link
Member Author

ramonsmits commented Feb 6, 2025

@danielmarbach @andreasohlund There are multiple commits, one for audit, one for error, and one for domain events. Issue it that seems like a very deep rabbit hole as many handlers invoke storage and all of these do not support cancellation.

As cancellation itself isn't really a bug but an improvement.

As audit is the most affected I think it makes sense to support cancellation there and for the remaning parts to create cruft issues as it is a lot of effort to add cancellation to all those operations.

What is your opinion?

@ramonsmits ramonsmits changed the base branch from master to hanging-ingestion February 6, 2025 23:46
@danielmarbach
Copy link
Contributor

for the remaning parts to create cruft issues as it is a lot of effort to add cancellation to all those operations.

FYI During the modernization efforts we deliberately had to stop at some point. It was just too much effort and also not in all cases glaringly obvious what the effects of cancellation might have on the stability of the code paths calling it so we did cut off somewhere.

@ramonsmits ramonsmits force-pushed the hanging-ingestion branch 2 times, most recently from b779f00 to b8d5744 Compare February 10, 2025 13:00
Base automatically changed from hanging-ingestion to master February 11, 2025 08:49
@mauroservienti mauroservienti self-requested a review February 18, 2025 10:17
@ramonsmits ramonsmits force-pushed the ingestion-cancellation-support branch from 4fb3818 to 825bc8f Compare March 6, 2025 11:19
@ramonsmits ramonsmits force-pushed the ingestion-cancellation-support branch from 08e1059 to 011ed4e Compare March 11, 2025 09:33
@ramonsmits ramonsmits marked this pull request as ready for review March 11, 2025 11:28
@mauroservienti mauroservienti added this to the vNext milestone Mar 12, 2025
@ramonsmits ramonsmits changed the title Support cancellation of ingestion operations Support cancellation of api and primarily audit storage operations Mar 13, 2025
@ramonsmits ramonsmits changed the title Support cancellation of api and primarily audit storage operations Support cancellation of web api and audit storage operations Mar 13, 2025
@ramonsmits ramonsmits merged commit 17d5c3e into master Mar 13, 2025
32 checks passed
@ramonsmits ramonsmits deleted the ingestion-cancellation-support branch March 13, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants