Skip to content

Fix watchdog re-creation of TransportInfrastructure and cancellation improvements #4818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mauroservienti merged 14 commits into from
Mar 6, 2025
Merged

Fix watchdog re-creation of TransportInfrastructure and cancellation improvements #4818

mauroservienti merged 14 commits into from
Mar 6, 2025

Conversation

@ramonsmits
Copy link
Member

@ramonsmits ramonsmits commented Feb 14, 2025 •
edited
Loading

  • Watchdog didn't invoke TransportInfrastructure.Shutdown
  • Added maximum start timeout
  • Watchdog stop now supports cancellation
  • Watchdog stop no longer hiding failing stop and throws

@ramonsmits ramonsmits changed the title Watchdog stop passed CancellationToken.None which could block stop till infinity Fix leaking TransportInfrastructure and various watchdog cancellation issues Feb 14, 2025
@ramonsmits ramonsmits self-assigned this Feb 14, 2025
andreasohlund
andreasohlund reviewed Feb 20, 2025
View reviewed changes
ramonsmits
ramonsmits commented Feb 20, 2025
View reviewed changes
ramonsmits
ramonsmits commented Feb 25, 2025
View reviewed changes
@andreasohlund andreasohlund marked this pull request as ready for review March 4, 2025 12:17
@ramonsmits ramonsmits changed the title Fix leaking TransportInfrastructure and various watchdog cancellation issues Fix watchdog re-creation of TransportInfrastructure and cancellation improvements Mar 4, 2025
@ramonsmits
- Applied changes from audit to error
286ec83 
- Removed duplication in EnsureStopped
- Removed log events around semaphore handling
@mauroservienti mauroservienti merged commit fca1ba5 into master Mar 6, 2025
32 checks passed
@mauroservienti mauroservienti deleted the fix-watchdog-stop branch March 6, 2025 09:03
@mauroservienti mauroservienti mentioned this pull request Mar 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauroservienti mauroservienti mauroservienti approved these changes

@andreasohlund andreasohlund Awaiting requested review from andreasohlund

Assignees

@ramonsmits ramonsmits

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ramonsmits @andreasohlund @mauroservienti