-
Notifications
You must be signed in to change notification settings - Fork 48
Allow JIT killing of Raven.Embedded.EmbeddedServer by tearing it down as part of stop sequence #4824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow JIT killing of Raven.Embedded.EmbeddedServer by tearing it down as part of stop sequence #4824
Conversation
src/ServiceControl.Audit.Persistence.RavenDB/IRavenPersistenceLifecycle.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl.Audit.Persistence.RavenDB/RavenEmbeddedPersistenceLifecycle.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl.Audit.Persistence.RavenDB/RavenExternalPersistenceLifecycle.cs
Outdated
Show resolved
Hide resolved
|
I was just looking at what |
@johnsimons I have been looking at that too: We could clone that code into our code base but it would just be better if they would have a client. |
Do we even need to do that, like I said it is just a wrapper around Process.Start .... Process.End, TBH, not very useful |
…that we kill the instance if needed as adhering to cancellation is not possible in host builder root container dispose.
…at even supported?
Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>
…Dispose always gets invoked, added comment and improved code readability
fded2c5 to
6c53404
Compare
src/ServiceControl.Persistence.RavenDB/IRavenPersistenceLifecycle.cs
Outdated
Show resolved
Hide resolved
…cle.cs Co-authored-by: Mauro Servienti <mauro.servienti@gmail.com>
Teardown Raven.Embedded.EmbeddedServer as part of stop sequence so that we kill the instance if needed as adhering to cancellation is not possible in host builder root container dispose.
When the Embedded RavenDB client supports a Stop with cancellation this code can be simplified.