Skip to content

Conversation

@ramonsmits
Copy link
Member

@ramonsmits ramonsmits commented Feb 18, 2025

Teardown Raven.Embedded.EmbeddedServer as part of stop sequence so that we kill the instance if needed as adhering to cancellation is not possible in host builder root container dispose.

When the Embedded RavenDB client supports a Stop with cancellation this code can be simplified.

@andreasohlund andreasohlund marked this pull request as ready for review February 19, 2025 11:14
@johnsimons
Copy link
Member

I was just looking at what EmbededServer is, and it seems to be just a wrapper for the RavenDB server process.
Which makes me wonder if we could do a better job by just implementing that code ourselves.
Has this been considered at all?

@ramonsmits
Copy link
Member Author

I was just looking at what EmbededServer is, and it seems to be just a wrapper for the RavenDB server process. Which makes me wonder if we could do a better job by just implementing that code ourselves. Has this been considered at all?

@johnsimons I have been looking at that too:

We could clone that code into our code base but it would just be better if they would have a client.

@johnsimons
Copy link
Member

We could clone that code into our code base but it would just be better if they would have a client.

Do we even need to do that, like I said it is just a wrapper around Process.Start .... Process.End, TBH, not very useful

@ramonsmits ramonsmits marked this pull request as draft March 3, 2025 14:30
Base automatically changed from logging-improvements to master March 4, 2025 07:44
@mauroservienti mauroservienti added this to the vNext milestone Mar 13, 2025
@ramonsmits ramonsmits force-pushed the ravendb-teardown-during-stop-sequence branch from fded2c5 to 6c53404 Compare March 13, 2025 14:55
@ramonsmits ramonsmits marked this pull request as ready for review March 13, 2025 14:56
@mauroservienti mauroservienti enabled auto-merge (squash) March 14, 2025 09:45
@mauroservienti mauroservienti merged commit 9812d0b into master Mar 14, 2025
32 checks passed
@mauroservienti mauroservienti deleted the ravendb-teardown-during-stop-sequence branch March 14, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants