MessagesViewIndex change #4831
Closed
MessagesViewIndex change #4831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `.Values` directly
…type 'KeyValuePair<dynamic, dynamic>' and '<null>'
…eric.IEnumerable<object>' to 'System.Collections.Generic.IEnumerable<string>'
…ions.Generic.IEnumerable<object>' to 'System.Collections.Generic.IEnumerable<string>'" This reverts commit 0fa5bba.
…ands of type 'KeyValuePair<dynamic, dynamic>' and '<null>'" This reverts commit 5bcee0f.
This reverts commit 0e16305.
…nnot use `.Values` directly" This reverts commit b39f674.
ramonsmits
commented
Mar 11, 2025
| { | ||
| Map = messages => | ||
| from message in messages | ||
| let metadata = message.MessageMetadata |
Member
Author
There was a problem hiding this comment.
@mauroservienti I was banging my head against the wall... but I think let somehow is not supported. Could you quickly review the CI build? The error is about object but it does not make sense to me.
Issue it to that I for some reason cannot run these test locally so I cannot easily run them
Member
Author
|
Closing, not really much to gain except a slightly improved array allocation which isn't going to make a big difference performance wise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.