Improved installer progress messages and no longer timeout when setup/upgrade taking a long time to complete #4835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasohlund
commented
Feb 24, 2025
andreasohlund
commented
Feb 24, 2025
andreasohlund
commented
Feb 24, 2025
andreasohlund
commented
Feb 24, 2025
andreasohlund
commented
Feb 24, 2025
andreasohlund
commented
Feb 24, 2025
ramonsmits
approved these changes
Feb 25, 2025
Member
ramonsmits
left a comment
ramonsmits
left a comment
There was a problem hiding this comment.
As discussed, timeout duration and killing behavior will be addressed in a secondary PR.
Co-authored-by: Mauro Servienti <mauro.servienti@gmail.com>
ramonsmits
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR setup/upgrade could show the message "Creating queue...." for a very long time while in reality it started the child database process which can run a lenghty recovery operation.
This refactores setup routing to improve setup progress messages and show a proper message :
It also now infinitely waits for the setup process to exit and no longer kills it to ensure the setup will not leave the filesytem in a corrupted state.