[SPIKE] Add LavinMQ version and extra connection requirement - DO NOT MERGE #4838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| var rabbitVersion = obj["rabbitmq_version"] ?? obj["product_version"]; | ||
| var rabbitVersion = obj["rabbitmq_version"] ?? obj["product_version"] ?? obj["lavinmq_version"]; |
Contributor
There was a problem hiding this comment.
Will this report the LavinMQ version number as the RabbitMQ version in the broker metadata?
I'm not sure that's what we want to do. Shouldn't we identify it's actually LavinMQ and not RabbitMQ somehow?
Contributor
Author
There was a problem hiding this comment.
At this stage - this is just a spike. It is all "wrong" as the transport is rabbitmq and all docs etc, including SP display will say rabbitmq
jpalac
commented
Feb 26, 2025
| // https://github.com/Particular/ServiceControl/issues/4493 | ||
| httpClient = CreateHttpClient(defaultCredential, apiUrl); | ||
| var authToken = Convert.ToBase64String(System.Text.Encoding.ASCII.GetBytes($"{username}:{password}")); | ||
| httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Basic", authToken); |
Contributor
Author
There was a problem hiding this comment.
This sends the credentials in plain text which is not what we want and we would want to change this.
Using PreAuthenticate = true, on the httpclient instead of setting this header directly does not work.
jpalac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the output of the Exploration multi topic task force working on the LavingMQ compatibility issue
It makes small adjustments to enable ServiceControl to connect to LavinMQ using the RabbitMQ transport.