Remove header instead #4839
Merged
Remove header instead #4839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsimons
force-pushed
the
john/remove_header
branch
from
aaf424b to
c5d41ef
Compare
PhilBastian
requested changes
Feb 27, 2025
src/ServiceControl.MultiInstance.AcceptanceTests/Recoverability/WhenRetrying.cs
Outdated
Show resolved
Hide resolved
...Control.MultiInstance.AcceptanceTests/Recoverability/WhenRetryingSameMessageMultipleTimes.cs
Outdated
Show resolved
Hide resolved
...Control.MultiInstance.AcceptanceTests/Recoverability/WhenRetryingSameMessageMultipleTimes.cs
Show resolved
Hide resolved
…y/WhenRetrying.cs Co-authored-by: Phil Bastian <155411597+PhilBastian@users.noreply.github.com>
johnsimons
force-pushed
the
john/remove_header
branch
from
47216aa to
c9419f9
Compare
PhilBastian
approved these changes
Feb 27, 2025
Member
|
@johnsimons @PhilBastian, could a meaningful description of the changes and how they fix the linked bugs be added to the PR? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of fixing a bug with edit and retry logic, this patch was applied but it seems setting a header to an empty string causes side effects.
This PR addresses the following bug introduced: