Skip to content

Add tests to make sure that indexes being locked prevents index resets on instance restarts #4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andreasohlund merged 8 commits into from
Mar 3, 2025
Merged

Add tests to make sure that indexes being locked prevents index resets on instance restarts #4849

andreasohlund merged 8 commits into from
Mar 3, 2025

Conversation

@andreasohlund
Copy link
Member

@andreasohlund andreasohlund commented Feb 28, 2025 •
edited
Loading

This means that user can opt-into Lucene by doing the following in Raven Studio:

  1. Overriding search engine type to Lucene for a specific index
  2. Lock the index with LockMode set to Ignore

@andreasohlund andreasohlund mentioned this pull request Feb 28, 2025
Closed
@andreasohlund andreasohlund changed the title Handle indexes being locked to prevent resets on instance restarts Make sure that indexes being locked to prevent resets on instance restarts is handled Feb 28, 2025
@andreasohlund andreasohlund self-assigned this Feb 28, 2025
@andreasohlund andreasohlund changed the title Make sure that indexes being locked to prevent resets on instance restarts is handled Add tests to make sure that indexes being locked prevents index resets on instance restarts Mar 1, 2025
@andreasohlund andreasohlund marked this pull request as ready for review March 1, 2025 11:17
@andreasohlund
Copy link
Member Author

andreasohlund commented Mar 1, 2025

@mauroservienti I called YAGNI on try catch and log the exception if index is locked with error

@andreasohlund andreasohlund enabled auto-merge (squash) March 1, 2025 15:00
@andreasohlund andreasohlund merged commit 0e39e56 into master Mar 3, 2025
32 checks passed
@andreasohlund andreasohlund deleted the honor-search-engine-type branch March 3, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauroservienti mauroservienti mauroservienti approved these changes

@ramonsmits ramonsmits Awaiting requested review from ramonsmits

Assignees

@andreasohlund andreasohlund

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreasohlund @mauroservienti