Skip to content

Mark flaky tests as explicit #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bording merged 1 commit into from
Feb 28, 2025
Merged

Mark flaky tests as explicit #4851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...trol.MultiInstance.AcceptanceTests/Recoverability/WhenRetryingSameMessageMultipleTimes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public enum RetryType
Edit
}

[Explicit]
[TestCase(new[] { RetryType.NoEdit, RetryType.NoEdit, RetryType.Edit })]
[TestCase(new[] { RetryType.Edit, RetryType.NoEdit, RetryType.Edit })]
[TestCase(new[] { RetryType.NoEdit, RetryType.Edit, RetryType.NoEdit })]
Expand Down
4 changes: 2 additions & 2 deletions src/ServiceControl.MultiInstance.AcceptanceTests/Recoverability/WhenRetryingWithEdit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ namespace ServiceControl.MultiInstance.AcceptanceTests.Recoverability;
using NServiceBus.AcceptanceTesting;
using NServiceBus.Settings;
using NUnit.Framework;
using TestSupport;
using ServiceControl.Infrastructure;
using TestSupport;

class WhenRetryingWithEdit : WhenRetrying
{
[Test]
[Test, Explicit]
public async Task ShouldCreateNewMessageAndResolveEditedMessage()
{
CustomServiceControlPrimarySettings = s => { s.AllowMessageEditing = true; };
Expand Down