Skip to content

Conversation

@andreasohlund
Copy link
Member

No description provided.

Copy link
Member

@mauroservienti mauroservienti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that waiting forever is the best approach here. We should be waiting longer than 1 minute for sure, but then show users a warning message that explains what's going on and what they could do to mitigate the problem. E.g., open the RavenDB studio, pause the message view index, go back to SCMU and try again.

@ramonsmits
Copy link
Member

Indeed, reporting progress would be a nice to have but the primary reason for needing to wait very long is because the database could be recovering.

I still think we should wait "till infinity" for setup and never kill it. Abandoning it to me is incorrect as now a process is running on the system for which the user doesn't know WHAT process it is and what to do with it.

The only thing is that we would improvement the reporting. Stating, "this can take a very long time to complete. If this takes longer then 10 minutes review the logs and contact Particular Support if assistance is required"

Only if the installer itself supports "cancellation" then it could have a CancellationTokenSource that triggers after for example 5 minutes but what if the setup could run and wait until the database is in a "healthy" state?

@andreasohlund andreasohlund changed the title Wait indefinite for the setup to complete to minmize the risk for a corrupted database Do not kill instance setup to minmize the risk for a corrupted database Mar 5, 2025
@andreasohlund andreasohlund marked this pull request as ready for review March 5, 2025 12:30
@andreasohlund
Copy link
Member Author

@mauroservienti I've discussed with Ramon and we think infinite wait is the way to go for now, comment added to explain

@ramonsmits ramonsmits changed the title Do not kill instance setup to minmize the risk for a corrupted database Do not kill instance setup to minimize the risk for a corrupted database Mar 5, 2025
@andreasohlund andreasohlund merged commit 337b6c0 into master Mar 6, 2025
32 checks passed
@andreasohlund andreasohlund deleted the infinite-wait branch March 6, 2025 06:46
@mauroservienti mauroservienti added this to the vNext milestone Mar 12, 2025
@andreasohlund andreasohlund removed this from the 6.5.0 milestone Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants