-
Notifications
You must be signed in to change notification settings - Fork 48
Do not kill instance setup to minimize the risk for a corrupted database #4852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mauroservienti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that waiting forever is the best approach here. We should be waiting longer than 1 minute for sure, but then show users a warning message that explains what's going on and what they could do to mitigate the problem. E.g., open the RavenDB studio, pause the message view index, go back to SCMU and try again.
|
Indeed, reporting progress would be a nice to have but the primary reason for needing to wait very long is because the database could be recovering. I still think we should wait "till infinity" for setup and never kill it. Abandoning it to me is incorrect as now a process is running on the system for which the user doesn't know WHAT process it is and what to do with it. The only thing is that we would improvement the reporting. Stating, "this can take a very long time to complete. If this takes longer then 10 minutes review the logs and contact Particular Support if assistance is required" Only if the installer itself supports "cancellation" then it could have a CancellationTokenSource that triggers after for example 5 minutes but what if the setup could run and wait until the database is in a "healthy" state? |
1e1f30e to
28fe88d
Compare
|
@mauroservienti I've discussed with Ramon and we think infinite wait is the way to go for now, comment added to explain |
No description provided.