Skip to content

Also support ServiceControl.Audit/IngestAuditMessages #4858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonsmits merged 2 commits into from
Mar 11, 2025
Merged

Also support ServiceControl.Audit/IngestAuditMessages #4858

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8d9e6d
Also support `ServiceControl.Audit/IngestAuditMessages` to avoid conf…
ramonsmits Mar 3, 2025
e59f772
Move creation close to only usage
ramonsmits Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/ServiceControl.Audit/Infrastructure/Settings/Settings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,14 @@ void LoadAuditQueueInformation()
throw new Exception("ServiceBus/AuditQueue value is required to start the instance");
}

IngestAuditMessages = SettingsReader.Read(new SettingsRootNamespace("ServiceControl"), "IngestAuditMessages", true);
if (!SettingsReader.TryRead(SettingsRootNamespace, "IngestAuditMessages", out bool ingestAuditMessages))
{
// Backwards compatibility
var serviceControlNamespace = new SettingsRootNamespace("ServiceControl");
ingestAuditMessages = SettingsReader.Read(serviceControlNamespace, "IngestAuditMessages", true);
}

IngestAuditMessages = ingestAuditMessages;

if (IngestAuditMessages == false)
{
Expand Down