Skip to content

Conversation

@andreasohlund
Copy link
Member

@andreasohlund andreasohlund commented Mar 6, 2025

  • Uses DI instead
  • All metrics consolidated in a single class
  • Cut down on the number of dimensions to avoid performance issues for metrics storage
  • No need to separate counters when there is a histogram (you get counters for "free" with them)
  • Aligns naming with https://prometheus.io/docs/practices/naming/

@andreasohlund andreasohlund requested a review from ramonsmits March 6, 2025 17:48
@andreasohlund andreasohlund self-assigned this Mar 7, 2025
@andreasohlund andreasohlund marked this pull request as ready for review March 9, 2025 12:02
@andreasohlund
Copy link
Member Author

I've done some testing and metrics now works fine without overloading Prometheus due to unbounded dimensions

@andreasohlund andreasohlund enabled auto-merge (squash) March 9, 2025 12:12
@andreasohlund andreasohlund merged commit c6f725d into master Mar 9, 2025
26 of 32 checks passed
@andreasohlund andreasohlund deleted the metrics-improvements branch March 9, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants