Add a RavenDB dirty memory custom check #4868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonsmits
reviewed
Mar 11, 2025
src/ServiceControl.Audit.Persistence.RavenDB/CustomChecks/CheckDirtyMemory.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl.Audit.Persistence.RavenDB/CustomChecks/CheckDirtyMemory.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl.Audit.Persistence.RavenDB/MemoryInformationRetriever.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl.Audit.Persistence.RavenDB/MemoryInformationRetriever.cs
Outdated
Show resolved
Hide resolved
bording
reviewed
Mar 11, 2025
src/ServiceControl.Audit.Persistence.RavenDB/CustomChecks/CheckDirtyMemory.cs
Outdated
Show resolved
Hide resolved
mauroservienti
changed the title
mauroservienti
force-pushed
the
dirty-memory-custom-check
branch
from
7544927 to
151e29d
Compare
It'll be added in a separate PR
Member
Author
|
@andreasohlund @ramonsmits this is ready for a review |
src/ServiceControl.Audit.Persistence.RavenDB/CustomChecks/CheckDirtyMemory.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl.Audit.Persistence.RavenDB/MemoryInformationRetriever.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl.Persistence.RavenDB/CustomChecks/CheckDirtyMemory.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl.Persistence.RavenDB/MemoryInformationRetriever.cs
Outdated
Show resolved
Hide resolved
mauroservienti
commented
Mar 14, 2025
src/ServiceControl.Persistence.RavenDB/CustomChecks/CheckDirtyMemory.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>
src/ServiceControl.Persistence.RavenDB/CustomChecks/CheckDirtyMemory.cs
Outdated
Show resolved
Hide resolved
andreasohlund
approved these changes
Mar 14, 2025
ramonsmits
approved these changes
Mar 14, 2025
This was referenced Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a RavenDB dirty memory custom check. RavenDB dirty memory is the amount of data that needs to be flushed to disk. Flushing happens in a background thread. Under heavy load, that thread might be de-prioritized, causing the amount of dirty memory to increase. When that happens, shutting down the RavenDB (embedded) instance takes much time.
The custom check invokes a RavenDB HTTP admin endpoint (
/admin/debug/memory/stats?includeThreads=false&includeMappings=false) to retrieve memory stats.The custom check links to the documentation/guidance describing how to address/mitigate these scenarios.