Skip to content

Primary instance MemoryInformationRetriever init now supports supports external and embedded instances #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mauroservienti merged 1 commit into from
Mar 14, 2025
Merged

Primary instance MemoryInformationRetriever init now supports supports external and embedded instances #4882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ServiceControl.Persistence.RavenDB/MemoryInformationRetriever.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ class MemoryInformationRetriever(RavenPersisterSettings persisterSettings)
// What does a connection string look like? Is it only a URI or could it contain other stuff?
// The primary instance has only the concept of a connection string (vs the Audit instance having
// both a ServiceUrl and a ConnectionString). If the connection string contain always only the
// server URL, this code is safe, otherwise it need to be adjusted to extract the server URL.
readonly HttpClient client = new() { BaseAddress = new Uri(persisterSettings.ConnectionString) };
// server URL, this code is safe, otherwise it need to be adjusted to extract the server URL.
readonly HttpClient client = new() { BaseAddress = new Uri(persisterSettings.ServerUrl ?? persisterSettings.ConnectionString) };

record ResponseDto
{
Expand Down