Add backoff timeout when the async timer fails #4891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasohlund
commented
Mar 19, 2025
andreasohlund
commented
Mar 19, 2025
andreasohlund
changed the title
ramonsmits
reviewed
Mar 20, 2025
ramonsmits
reviewed
Mar 20, 2025
ramonsmits
approved these changes
Mar 20, 2025
Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen logs being flooded by the coding using the async timer during failure scenarios.
To prevent this an exponential backoff strategy capped at 60s will be used for consecutive failures executing the async timer.