-
Notifications
You must be signed in to change notification settings - Fork 48
Remove analyser for configure await #4898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| dotnet_diagnostic.CA1710.severity = error | ||
| dotnet_diagnostic.CA1711.severity = error | ||
| dotnet_diagnostic.CA2007.severity = error | ||
| dotnet_diagnostic.CA2007.severity = none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this be reset by repo sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, didn't think about that, is there a workaround for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bording is there some way to override this on the /src level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No there isn't. If want to make this change, you need to add an .editorconfig file to every project to disable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it so the only (future) option would be to have different editor configs for "library" repos vs "non-library" repos where that setting could be different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no way to have that sort of variation given the way RepoSync is implemented.
|
Agreed the analyzer is not required here |
|
Repo sync will override this change if we merge it. Closing. |
Since I don't see a use case where SC would need to set it
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2007#when-to-suppress-warnings