Skip to content

ServiceControl Audit Ingestion throwing NREs with audit forwarding enabled #4905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bording merged 1 commit into from
Mar 21, 2025
Merged

ServiceControl Audit Ingestion throwing NREs with audit forwarding enabled #4905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/ServiceControl.Audit/Auditing/AuditIngestor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ public async Task Ingest(List<MessageContext> contexts, CancellationToken cancel

Task Forward(IReadOnlyCollection<MessageContext> messageContexts, string forwardingAddress, CancellationToken cancellationToken)
{
var transportOperations = new TransportOperation[messageContexts.Count]; //We could allocate based on the actual number of ProcessedMessages but this should be OK
var index = 0;
var transportOperations = new List<TransportOperation>(messageContexts.Count);
MessageContext anyContext = null;
foreach (var messageContext in messageContexts)
{
Expand All @@ -90,13 +89,12 @@ Task Forward(IReadOnlyCollection<MessageContext> messageContexts, string forward
// Forwarded messages should last as long as possible
outgoingMessage.Headers.Remove(Headers.TimeToBeReceived);

transportOperations[index] = new TransportOperation(outgoingMessage, new UnicastAddressTag(forwardingAddress));
index++;
transportOperations.Add(new TransportOperation(outgoingMessage, new UnicastAddressTag(forwardingAddress)));
}

return anyContext != null
? messageDispatcher.Value.Dispatch(
new TransportOperations(transportOperations),
new TransportOperations([.. transportOperations]),
anyContext.TransportTransaction, cancellationToken)
: Task.CompletedTask;
}
Expand Down