Dirty memory custom check may fail connecting to RavenDB when using external mode #4917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enDB to retrieve dirty memory details
andreasohlund
approved these changes
Mar 28, 2025
bording
approved these changes
Mar 28, 2025
mauroservienti
added a commit
that referenced
this pull request
Apr 1, 2025
… mode (#4917) * Favor connection string over server URL when trying to connect to RavenDB to retrieve dirty memory details * Update comment to reflect reality * Update audit comment --------- Co-authored-by: Brandon Ording <bording@gmail.com>
mauroservienti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RavenDB persister (both for the primary and the audit instances) always sets the ServerUrl value to
localhostusing the configured maintenance port. When running in external mode and RavenDB is on the same machine or the RavenDB container is in the same network,localhostmay work, and the persisted connection string and server URL values match. However, it's better to favor using the connection string over the server URL when connecting to RavenDB to retrieve dirty memory details, and fallback to the server URL if the connection string is not set.