Refine test to show minimal metadata needed for errors to be imported successfully #4943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonsmits
reviewed
Apr 22, 2025
...Tests/Recoverability/MessageFailures/When_processing_message_with_missing_metadata_failed.cs
Show resolved
Hide resolved
ramonsmits
reviewed
Apr 22, 2025
...Tests/Recoverability/MessageFailures/When_processing_message_with_missing_metadata_failed.cs
Show resolved
Hide resolved
ramonsmits
reviewed
Apr 22, 2025
Member
Indeed, that should be optional but requires SP/SC changes.
The header might be auto generated based on the transport message ID in some transports. Where are you referring to? It isn't obvious in the diff from this PR. |
… for UX experience
Member
Author
|
@ramonsmits I've created separate tests for what is needed for ingestion to work vs what is needed for the UI to render reasonably. See if you like it |
ramonsmits
reviewed
Apr 25, 2025
...ceTests/Recoverability/MessageFailures/When_ingesting_failed_message_with_missing_headers.cs
Outdated
Show resolved
Hide resolved
ramonsmits
reviewed
Apr 25, 2025
...ceTests/Recoverability/MessageFailures/When_ingesting_failed_message_with_missing_headers.cs
Outdated
Show resolved
Hide resolved
ramonsmits
reviewed
Apr 25, 2025
...ceTests/Recoverability/MessageFailures/When_ingesting_failed_message_with_missing_headers.cs
Outdated
Show resolved
Hide resolved
ramonsmits
approved these changes
Apr 25, 2025
Member
ramonsmits
left a comment
ramonsmits
left a comment
There was a problem hiding this comment.
LGTM except for the string values
Member
Author
|
Good catch, replaced with constants now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some testing to figure out which minimal set of metadata is needed for error imports to work.
Notes:
ProcessingMachinefeels off, I think we should default it to null or unknown to be more flexible when importingI will raise follow-up PRs to address the above