Failed messages retried with Edit&Retry get stuck in the connector poison queue #4973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afprtclr
force-pushed
the
bugfix/setting-error-queue-name-on-retry
branch
2 times, most recently
from
97df515 to
957290a
Compare
afprtclr
force-pushed
the
bugfix/setting-error-queue-name-on-retry
branch
from
957290a to
893ae51
Compare
lailabougria
approved these changes
May 14, 2025
src/ServiceControl.Persistence.Tests/Recoverability/EditMessageTests.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl.Persistence.Tests/Recoverability/EditMessageTests.cs
Outdated
Show resolved
Hide resolved
…eTests.cs Co-authored-by: Laila Bougria <laila.bougria@particular.net>
…eTests.cs Co-authored-by: Laila Bougria <laila.bougria@particular.net>
ramonsmits
approved these changes
May 15, 2025
afprtclr
added a commit
that referenced
this pull request
May 15, 2025
* Setting proper queue name on edit & retry * Update src/ServiceControl.Persistence.Tests/Recoverability/EditMessageTests.cs Co-authored-by: Laila Bougria <laila.bougria@particular.net> * Update src/ServiceControl.Persistence.Tests/Recoverability/EditMessageTests.cs Co-authored-by: Laila Bougria <laila.bougria@particular.net> * ⚜️ small code improvements --------- Co-authored-by: Laila Bougria <laila.bougria@particular.net> Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
afprtclr
added a commit
that referenced
this pull request
May 15, 2025
* Setting proper queue name on edit & retry * Update src/ServiceControl.Persistence.Tests/Recoverability/EditMessageTests.cs * Update src/ServiceControl.Persistence.Tests/Recoverability/EditMessageTests.cs * ⚜️ small code improvements --------- Co-authored-by: Laila Bougria <laila.bougria@particular.net> Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
ramonsmits
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Edit&Retryget stuck in the connector poison queue #4977This sets the proper queue name when using "Edit & Retry" functionality.
Demo of fix:
Description.mp4