Skip to content

Update dependency NLog.Extensions.Logging to v6 #5078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependencyupdates wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −7
Open

Update dependency NLog.Extensions.Logging to v6 #5078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7088e2e
Update dependency NLog.Extensions.Logging to v6
dependencyupdates[bot] Feb 13, 2026
aa1f7c5
Use v6 NLog.Extensions compliant archiving
abparticular Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageVersion Include="Microsoft-WindowsAPICodePack-Shell" Version="1.1.5" />
<PackageVersion Include="Mindscape.Raygun4Net.NetCore" Version="11.2.5" />
<PackageVersion Include="NLog.Extensions.Logging" Version="5.5.0" />
<PackageVersion Include="NLog.Extensions.Logging" Version="6.1.1" />
<PackageVersion Include="NServiceBus" Version="10.1.0" />
<PackageVersion Include="NServiceBus.AcceptanceTesting" Version="10.1.0" />
<PackageVersion Include="NServiceBus.AmazonSQS" Version="9.0.0" />
Expand Down
2 changes: 1 addition & 1 deletion src/ServiceControl.Audit/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
}
else
{
LoggingConfigurator.ConfigureNLog("bootstrap.${shortdate}.txt", "./", NLog.LogLevel.Fatal);
LoggingConfigurator.ConfigureNLog("bootstrap.txt", "./", NLog.LogLevel.Fatal);
NLog.LogManager.GetCurrentClassLogger().Fatal(ex, "Unrecoverable error");
}
throw;
Expand Down
5 changes: 2 additions & 3 deletions src/ServiceControl.Infrastructure/LoggingConfigurator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static void ConfigureLogging(LoggingSettings loggingSettings)
}

var logLevel = loggingSettings.LogLevel.ToNLogLevel();
var loggingTo = ConfigureNLog("logfile.${shortdate}.txt", loggingSettings.LogPath, loggingSettings.LogLevel.ToNLogLevel());
var loggingTo = ConfigureNLog("logfile.txt", loggingSettings.LogPath, loggingSettings.LogLevel.ToNLogLevel());

//using LogManager here rather than LoggerUtil.CreateStaticLogger since this is exclusive to NLog
var logger = LogManager.GetLogger("LoggingConfiguration");
Expand All @@ -43,8 +43,7 @@ public static string ConfigureNLog(string logFileName, string logPath, LogLevel
Name = "file",
ArchiveEvery = FileArchivePeriod.Day,
FileName = Path.Combine(logPath, logFileName),
ArchiveFileName = Path.Combine(logPath, "logfile.{#}.txt"),
ArchiveNumbering = ArchiveNumberingMode.DateAndSequence,
ArchiveSuffixFormat = ".{1:yyyy-MM-dd}.{0:00}",
Layout = simpleLayout,
MaxArchiveFiles = 14,
ArchiveAboveSize = 30 * megaByte
Expand Down
2 changes: 1 addition & 1 deletion src/ServiceControl.Monitoring/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
}
else
{
LoggingConfigurator.ConfigureNLog("bootstrap.${shortdate}.txt", "./", NLog.LogLevel.Fatal);
LoggingConfigurator.ConfigureNLog("bootstrap.txt", "./", NLog.LogLevel.Fatal);
NLog.LogManager.GetCurrentClassLogger().Fatal(ex, "Unrecoverable error");
}
throw;
Expand Down
2 changes: 1 addition & 1 deletion src/ServiceControl/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
}
else
{
LoggingConfigurator.ConfigureNLog("bootstrap.${shortdate}.txt", "./", NLog.LogLevel.Fatal);
LoggingConfigurator.ConfigureNLog("bootstrap.txt", "./", NLog.LogLevel.Fatal);
NLog.LogManager.GetCurrentClassLogger().Fatal(ex, "Unrecoverable error");
}
throw;
Expand Down