Fix NullReferenceException when connected to RavenDB cloud
#5112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es not return memory information.
ramonsmits
requested review from
andreasohlund,
irinascurtu,
mauroservienti and
tmasternak
andreasohlund
approved these changes
Sep 9, 2025
mauroservienti
approved these changes
Sep 9, 2025
Member
mauroservienti
left a comment
mauroservienti
left a comment
There was a problem hiding this comment.
Other than, maybe, more readable, is is null any better?
src/ServiceControl.Audit.Persistence.RavenDB/MemoryInformationRetriever.cs
Outdated
Show resolved
Hide resolved
…Retriever.cs Co-authored-by: Mauro Servienti <mauro.servienti@gmail.com>
Member
Author
It is, |
src/ServiceControl.Persistence.RavenDB/MemoryInformationRetriever.cs
Outdated
Show resolved
Hide resolved
tmasternak
approved these changes
Sep 10, 2025
irinascurtu
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
NullReferenceExceptionwhen connected to RavenDB cloud which does not return memory information.