Skip to content

Allow ExpirationProcessTimerInSeconds to be set to 36 hours #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonsmits wants to merge 1 commit into from
Closed

Allow ExpirationProcessTimerInSeconds to be set to 36 hours #5113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/ServiceControl.Audit.Persistence.RavenDB/RavenPersistenceConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ static int GetExpirationProcessTimerInSeconds(PersistenceSettings settings)
expirationProcessTimerInSeconds = int.Parse(expirationProcessTimerInSecondsString);
}

var maxExpirationProcessTimerInSeconds = TimeSpan.FromHours(3).TotalSeconds;
var maxExpirationProcessTimerInSeconds = TimeSpan.FromHours(36).TotalSeconds; // Compatibility with RavenDB cloud free license

if (expirationProcessTimerInSeconds < 0)
{
Expand All @@ -156,6 +156,13 @@ static int GetExpirationProcessTimerInSeconds(PersistenceSettings settings)
return ExpirationProcessTimerInSecondsDefault;
}

var warningThresholdExpirationProcessTimerInSeconds = TimeSpan.FromHours(3).TotalSeconds;

if (expirationProcessTimerInSeconds > warningThresholdExpirationProcessTimerInSeconds)
{
Logger.LogError("It is not recommended to set `ExpirationProcessTimerInSeconds` above {WarningThresholdExpirationProcessTimerInSeconds} set ", warningThresholdExpirationProcessTimerInSeconds);
}

return expirationProcessTimerInSeconds;
}

Expand Down
Loading