Introduce an integration event for the Edit and Retry feature #5149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquirosj
force-pushed
the
ResolvedByEdit
branch
2 times, most recently
from
cec3fad to
7ebe491
Compare
Contributor
bartekwasielak
left a comment
bartekwasielak
left a comment
There was a problem hiding this comment.
I appreciate the changes of the methods' names. This helps with understanding a difference between the business message and the edit request.
....AcceptanceTests/Recoverability/ExternalIntegration/When_a_failed_msg_is_resolved_by_edit.cs
Show resolved
Hide resolved
bartekwasielak
force-pushed
the
ResolvedByEdit
branch
12 times, most recently
from
07c743e to
0c3d770
Compare
bartekwasielak
force-pushed
the
ResolvedByEdit
branch
3 times, most recently
from
c9c8baa to
b47687e
Compare
cquirosj
force-pushed
the
ResolvedByEdit
branch
from
b47687e to
0e7e1f4
Compare
bartekwasielak
force-pushed
the
ResolvedByEdit
branch
3 times, most recently
from
bf04965 to
95294e7
Compare
bartekwasielak
force-pushed
the
ResolvedByEdit
branch
6 times, most recently
from
b0ab6b0 to
1fc41b5
Compare
bartekwasielak
force-pushed
the
ResolvedByEdit
branch
from
1fc41b5 to
f715f3c
Compare
Co-authored-by: dependencyupdates[bot] <218638057+dependencyupdates[bot]@users.noreply.github.com> Update dependency PublicApiGenerator to 11.5.3 (#5202) Co-authored-by: dependencyupdates[bot] <218638057+dependencyupdates[bot]@users.noreply.github.com> Update actions/upload-artifact action to v5 (#5150) Co-authored-by: dependencyupdates[bot] <218638057+dependencyupdates[bot]@users.noreply.github.com> Update dependency NUnit.Analyzers to 4.10.0 (#5053) * Update dependency NUnit.Analyzers to 4.10.0 * Swap the assert * Make the class abstract --------- Co-authored-by: dependencyupdates[bot] <218638057+dependencyupdates[bot]@users.noreply.github.com> Co-authored-by: Tamara Rivera <tamita.rivera@gmail.com> Update dependency NUnit.Analyzers to 4.11.1 (#5152) Co-authored-by: dependencyupdates[bot] <218638057+dependencyupdates[bot]@users.noreply.github.com> Log email notification subject and body for all SendEmailNotificationHandler executions (#5139) * remove duplicate custom check - Audit Message Ingestion * add email notification subject and body to log * apply code review suggestions Ensure RetryAcknowledgementBehavior gets triggered WIP WIP2 Add MessageEditedAndRetried event Reedit WIP Using MessageFailed instead of MessageResolved - test Restoring original Handler Test editions format fix Added concurrency support formatting fixes Test modification Change contract types Adding more conditions to the test Reverting changes formatting fix
bartekwasielak
force-pushed
the
ResolvedByEdit
branch
from
f715f3c to
1ee9af4
Compare
bartekwasielak
changed the title
bartekwasielak
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a ServiceControl integration event (
MessageEditedAndRetried) that is dispatched every time an Edit and Retry takes place. With this event the user can programmatically track the status of the failed message (the fact it has been edited and retried).