Skip to content

Generating a usage report throws exception System.InvalidOperationException: Sequence contains more than one matching element #5184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ngallegos merged 1 commit into from
Nov 14, 2025
Merged

Generating a usage report throws exception System.InvalidOperationException: Sequence contains more than one matching element #5184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Particular.LicensingComponent.UnitTests/Infrastructure/DataStoreBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public DataStoreBuilder WithThroughput(ThroughputSource? source = null, DateOnly
}

source ??= endpoint.Id.ThroughputSource;
if (endpoints.SingleOrDefault(e => e.Id.Name == endpoint.Id.Name && e.Id.ThroughputSource == source) == null)
if (endpoints.FirstOrDefault(e => e.Id.Name == endpoint.Id.Name && e.Id.ThroughputSource == source) == null)
{
throw new InvalidOperationException(
$"Need to add endpoint {endpoint.Id.Name}:{source} before calling {nameof(WithThroughput)}");
Expand Down
71 changes: 49 additions & 22 deletions ...ingComponent.UnitTests/ThroughputCollector/ThroughputCollector_Report_Throughput_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ class ThroughputCollector_Report_Throughput_Tests : ThroughputCollectorTestFixtu
{
public override Task Setup()
{

SetExtraDependencies = d => { };
return base.Setup();
}
Expand Down Expand Up @@ -159,15 +158,15 @@ public async Task Should_return_correct_throughput_in_report_when_multiple_sourc
// Arrange
await DataStore.CreateBuilder()
.AddEndpoint("Endpoint1", sources: [ThroughputSource.Broker, ThroughputSource.Monitoring])
.WithThroughput(ThroughputSource.Broker, data: [50, 55])
.WithThroughput(ThroughputSource.Monitoring, data: [60, 65])
.WithThroughput(ThroughputSource.Broker, data: [50, 55])
.WithThroughput(ThroughputSource.Monitoring, data: [60, 65])
.AddEndpoint("Endpoint2", sources: [ThroughputSource.Broker, ThroughputSource.Audit])
.WithThroughput(ThroughputSource.Broker, data: [60, 65])
.WithThroughput(ThroughputSource.Audit, data: [61, 64])
.WithThroughput(ThroughputSource.Broker, data: [60, 65])
.WithThroughput(ThroughputSource.Audit, data: [61, 64])
.AddEndpoint("Endpoint3", sources: [ThroughputSource.Broker, ThroughputSource.Monitoring, ThroughputSource.Audit])
.WithThroughput(ThroughputSource.Broker, data: [50, 57])
.WithThroughput(ThroughputSource.Monitoring, data: [40, 45])
.WithThroughput(ThroughputSource.Audit, data: [42, 47])
.WithThroughput(ThroughputSource.Broker, data: [50, 57])
.WithThroughput(ThroughputSource.Monitoring, data: [40, 45])
.WithThroughput(ThroughputSource.Audit, data: [42, 47])
.Build();

// Act
Expand Down Expand Up @@ -218,10 +217,10 @@ public async Task Should_return_correct_throughput_in_report_when_data_from_mult
// Arrange
await DataStore.CreateBuilder()
.AddEndpoint("Endpoint1", sources: [ThroughputSource.Broker])
.WithThroughput(data: [50, 75])
.WithThroughput(data: [50, 75])
.AddEndpoint("Endpoint1_", sources: [ThroughputSource.Audit])
.ConfigureEndpoint(endpoint => endpoint.SanitizedName = "Endpoint1")
.WithThroughput(data: [60, 65])
.WithThroughput(data: [60, 65])
.Build();

// Act
Expand All @@ -244,27 +243,55 @@ await DataStore.CreateBuilder()
});
}

[TestCase(ThroughputSource.Audit)]
[TestCase(ThroughputSource.Broker)]
[TestCase(ThroughputSource.Monitoring)]
public async Task Should_return_correct_throughput_in_report_when_data_from_multiple_sources_of_same_type_exist(ThroughputSource source)
{
// Arrange
await DataStore.CreateBuilder()
.AddEndpoint("Endpoint1", sources: [source])
.WithThroughput(data: [50, 75])
.AddEndpoint("Endpoint1_", sources: [source])
.ConfigureEndpoint(endpoint => endpoint.SanitizedName = "Endpoint1")
.WithThroughput(data: [60, 65])
.Build();

// Act
var report = await ThroughputCollector.GenerateThroughputReport("", null, default);

// Assert
Assert.That(report, Is.Not.Null);
Assert.That(report.ReportData.Queues.Count, Is.EqualTo(1));

Assert.Multiple(() =>
{
Assert.That(report.ReportData.TotalThroughput, Is.EqualTo(75), $"Incorrect TotalThroughput recorded");
Assert.That(report.ReportData.TotalQueues, Is.EqualTo(1), $"Incorrect TotalQueues recorded");
});
}

[Test]
public async Task Should_generate_correct_report()
{
// Arrange
await DataStore.CreateBuilder()
.AddEndpoint("Endpoint1", sources: [ThroughputSource.Broker, ThroughputSource.Monitoring])
.WithThroughput(ThroughputSource.Broker, data: [50, 55], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.WithThroughput(ThroughputSource.Monitoring, data: [60, 65], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.ConfigureEndpoint(endpoint => endpoint.EndpointIndicators = [EndpointIndicator.KnownEndpoint.ToString()])
.WithThroughput(ThroughputSource.Broker, data: [50, 55], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.WithThroughput(ThroughputSource.Monitoring, data: [60, 65], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.ConfigureEndpoint(endpoint => endpoint.EndpointIndicators = [EndpointIndicator.KnownEndpoint.ToString()])
.AddEndpoint("Endpoint2", sources: [ThroughputSource.Broker, ThroughputSource.Audit])
.WithThroughput(ThroughputSource.Broker, data: [60, 65], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.WithThroughput(ThroughputSource.Audit, data: [61, 64], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.ConfigureEndpoint(endpoint => endpoint.EndpointIndicators = [EndpointIndicator.KnownEndpoint.ToString()])
.WithThroughput(ThroughputSource.Broker, data: [60, 65], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.WithThroughput(ThroughputSource.Audit, data: [61, 64], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.ConfigureEndpoint(endpoint => endpoint.EndpointIndicators = [EndpointIndicator.KnownEndpoint.ToString()])
.AddEndpoint("Endpoint3", sources: [ThroughputSource.Broker, ThroughputSource.Monitoring, ThroughputSource.Audit])
.WithThroughput(ThroughputSource.Broker, data: [50, 57], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.WithThroughput(ThroughputSource.Monitoring, data: [40, 45], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.WithThroughput(ThroughputSource.Audit, data: [42, 47], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.ConfigureEndpoint(endpoint => endpoint.EndpointIndicators = [EndpointIndicator.KnownEndpoint.ToString()])
.WithThroughput(ThroughputSource.Broker, data: [50, 57], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.WithThroughput(ThroughputSource.Monitoring, data: [40, 45], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.WithThroughput(ThroughputSource.Audit, data: [42, 47], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.ConfigureEndpoint(endpoint => endpoint.EndpointIndicators = [EndpointIndicator.KnownEndpoint.ToString()])
.AddEndpoint("Endpoint4", sources: [ThroughputSource.Broker])
.ConfigureEndpoint(endpoint => endpoint.UserIndicator = UserIndicator.PlannedToDecommission.ToString())
.WithThroughput(ThroughputSource.Broker, data: [42, 47], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.ConfigureEndpoint(endpoint => endpoint.UserIndicator = UserIndicator.PlannedToDecommission.ToString())
.WithThroughput(ThroughputSource.Broker, data: [42, 47], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
.AddEndpoint("Endpoint5", sources: [ThroughputSource.Broker])
.ConfigureEndpoint(endpoint => endpoint.UserIndicator = UserIndicator.NotNServiceBusEndpoint.ToString())
.WithThroughput(ThroughputSource.Broker, data: [15, 4], startDate: DateOnly.FromDateTime(new DateTime(2024, 4, 24)))
Expand Down
7 changes: 4 additions & 3 deletions src/Particular.LicensingComponent/ThroughputDataExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
static class ThroughputDataExtensions
{
public static IEnumerable<EndpointDailyThroughput> FromSource(this List<ThroughputData> throughputs, ThroughputSource source) => throughputs
.SingleOrDefault(td => td.ThroughputSource == source)?
.Select(kvp => new EndpointDailyThroughput(kvp.Key, kvp.Value)) ?? [];
.Where(td => td.ThroughputSource == source)
.SelectMany(td => td)
.Select(kvp => new EndpointDailyThroughput(kvp.Key, kvp.Value));

public static long Sum(this List<ThroughputData> throughputs) => throughputs.SelectMany(t => t).Sum(kvp => kvp.Value);

Expand Down Expand Up @@ -40,4 +41,4 @@ public static long MaxMonthlyThroughput(this List<ThroughputData> throughputs)

public static bool HasDataFromSource(this IDictionary<string, IEnumerable<ThroughputData>> throughputPerQueue, ThroughputSource source) =>
throughputPerQueue.Any(queueName => queueName.Value.Any(data => data.ThroughputSource == source && data.Count > 0));
}
}