Skip to content

Add authentication and SSL/TLS to ServiceControl #5197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
warwickschroeder wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Add authentication and SSL/TLS to ServiceControl #5197

warwickschroeder wants to merge 24 commits into from

Conversation

@warwickschroeder
Copy link

@warwickschroeder warwickschroeder commented Nov 24, 2025 •
edited
Loading

Addresses: Particular/ServicePulse#1723

  • Supports JWT bearer tokens, OpenID Connect, OAuth2.0.
  • Adds config for ServiceControl authentication. Defaults to disabled.
  • Adds config for ServicePulse authentication. Driven by ServiceControl auth.
  • Adds config for direct HTTPS hosting (kestral). Defaults to disabled.
  • Adds config for HTTPS redirect and HSTS
  • Adds config for stricter Forward Headers (reverse proxy). Defaults to "All" headers and "Any" proxies.
  • Adds config for stricter CORS. Defaults to "Allow Any Origin"

warwickschroeder
warwickschroeder commented Nov 26, 2025
View reviewed changes
@jasontaylordev jasontaylordev force-pushed the genxp-3600-add-authentication branch from de7cd32 to 45f7db3 Compare December 1, 2025 03:40
@warwickschroeder warwickschroeder changed the title Add initial authentication to ServiceControl Add authentication and SSL to ServiceControl Dec 3, 2025
warwickschroeder and others added 13 commits December 5, 2025 11:41
@warwickschroeder @jasontaylordev
Add initial authentication supporting JWT tokens, OpenID Connect, OAu…
03f7777 
…th2.0
@jasontaylordev
Add ServicePulse-specific OIDC configuration and endpoint
f8e77ff
@jasontaylordev @warwickschroeder
Update src/ServiceControl/App.config
af180a2 
Co-authored-by: Warwick Schroeder <warwick.schroeder@particular.net>
@jasontaylordev @warwickschroeder
Update src/ServiceControl/App.config
36dcabf 
Co-authored-by: Warwick Schroeder <warwick.schroeder@particular.net>
@jasontaylordev
Remove SP enabled flag
6510e9c
@jasontaylordev
Update approved routes and settings
f8069ef
@warwickschroeder @jasontaylordev
Allow multiple api scopes, or none. Add client audience config setting
352b4c8
@jasontaylordev
Add auth to other instances
1b3f5dc
@jasontaylordev
Rename to ApiScopes
87e6f95
@warwickschroeder @jasontaylordev
Add additional options for flexible and secure hosting; SSL/TLS, Reve…
44ef6da 
…rse Proxy, Direct HTTPS, CORS
@warwickschroeder @jasontaylordev
Remove previously added rate limit for anon api
c333302
@jasontaylordev
Forward auth header
575e2be
@jasontaylordev
Allow Anon for CheckRemotes
5e86040
@jasontaylordev jasontaylordev force-pushed the genxp-3600-add-authentication branch from 92500bc to 5e86040 Compare December 5, 2025 01:41
warwickschroeder
warwickschroeder commented Dec 8, 2025
View reviewed changes
Copy link
Author

@warwickschroeder warwickschroeder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im surprised these are pre-existing. What are they being used for in ServiceControl? Metric collection?

AWS token and Azure Identity packages

@jasontaylordev
Copy link
Contributor

jasontaylordev commented Dec 8, 2025

Im surprised these are pre-existing. What are they being used for in ServiceControl? Metric collection?

AWS token and Azure Identity packages

Assuming you're referring to this commit. In this case the Azure.Identity package is referenced by ServiceControl.Transports.ASBS, which is a transport adapter for Azure Service Bus.

@warwickschroeder
Copy link
Author

warwickschroeder commented Dec 8, 2025

Ah that makes sense. Thanks

Assuming you're referring to this commit. In this case the Azure.Identity package is referenced by ServiceControl.Transports.ASBS, which is a transport adapter for Azure Service Bus.

@warwickschroeder warwickschroeder changed the title Add authentication and SSL to ServiceControl Add authentication and SSL/TLS to ServiceControl Dec 10, 2025
@warwickschroeder warwickschroeder marked this pull request as ready for review December 11, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasontaylordev jasontaylordev jasontaylordev left review comments

@abparticular abparticular Awaiting requested review from abparticular

At least 1 approving review is required to merge this pull request.

Assignees

@jasontaylordev jasontaylordev

@warwickschroeder warwickschroeder

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@warwickschroeder @jasontaylordev