Validate installed binaries are not removed by external tool #5210
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBoike
force-pushed
the
validate-install
branch
from
662b3fc to
82c6887
Compare
hazel-bohon
reviewed
Dec 9, 2025
hazel-bohon
approved these changes
Dec 10, 2025
DavidBoike
added a commit
that referenced
this pull request
Dec 17, 2025
* Throw if 3rd-party security software removes a dependency during install * Increase delay to 1s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems it's possible for a 3rd-party security tool to delete one of the binaries written by ServiceControl Management during an install, creating an incomplete set of binaries that is unable to start.
This improvement checks to ensure that each binary that is expected to be present after an install is still present, and throws an exception otherwise, halting the install with an informative error message.