-
Notifications
You must be signed in to change notification settings - Fork 48
Improve SQS query time handling and CloudWatch metric collection logic #5234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… collection - Adjusted `Initialize` to use the most eastern timezone UTC offset for accurate time handling to validate internally using TUTC - Fixed Start/End timestamps to correctly be Utc - Upgraded `AWSSDK.CloudWatch` package to version 4.0.6.1 for latest fixes and improvements. - Replaced manual cancellation handling by utilizing `TestContext.CurrentContext.CancellationToken` to improve test cancellation flow.
andreasohlund
approved these changes
Dec 16, 2025
Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>
…azonSQSQueryTests`.
andreasohlund
approved these changes
Dec 18, 2025
- Added trace-level logging for skipped dates and query execution details. - Renamed variables for clarity (`startUtc` → `queryStartUtc`, `endUtc` → `queryendUtc`). - Adjusted log level for CloudWatch datapoints (`Information` → `Trace`).
…t in `AmazonSQSQueryTests`
…set with an actuall offset, `.GetUtcNow();` return a DateTimeOffset with that same offset (!!) while this MUST be a value without an offset.
ramonsmits
added a commit
to Particular/Particular.EndpointThroughputCounter
that referenced
this pull request
Dec 18, 2025
andreasohlund
approved these changes
Dec 18, 2025
mauroservienti
approved these changes
Dec 18, 2025
ramonsmits
added a commit
to Particular/Particular.EndpointThroughputCounter
that referenced
this pull request
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Start/End timestamps used to query SQS Cloudfront to correctly be Utc
AWSSDK.CloudWatchpackage to version 4.0.6.1 for latest fixes and improvements.TestContext.CurrentContext.CancellationTokento improve test cancellation flow