Point RavenDB Management Studio link to localhost #5237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why not just host RavenDB always on localhost? The hostname is more meant for SC API'sl, I don't see why the RavenDB api should be remotely accessible by everyone |
DharmishthaVPatel
force-pushed
the
ravendb-custom-host-name-bug-fix
branch
from
6ed16e7 to
51211ca
Compare
cquirosj
approved these changes
Dec 19, 2025
boblangley
approved these changes
Dec 19, 2025
cquirosj
added a commit
that referenced
this pull request
Dec 23, 2025
# Fix RavenDB Management Studio link binding issue ## Summary This PR fixes a property name mismatch introduced in PR #5237 that caused the RavenDB Management Studio hyperlink to be grayed out and non-functional in the ServiceControl Management UI. ## Problem After merging PR #5237 "Point RavenDB Management Studio link to localhost", the RavenDB Management Studio link in the Advanced Options maintenance mode section became unresponsive. The link appeared grayed out and clicking it had no effect. ## Root Cause PR #5237 renamed the property from `StorageUrl` to `RavenDbStudioUrl` in `ServiceControlBaseService.cs`, but the corresponding ViewModel property in `ServiceControlAdvancedViewModel.cs` was incorrectly named `RavenStudioUrl` (missing "Db"). This property name mismatch caused the WPF data binding to fail. ## Solution - Fixed property name in `ServiceControlAdvancedViewModel.cs` from `RavenStudioUrl` to `RavenDbStudioUrl` - This ensures proper binding between the ViewModel and the underlying ServiceControlInstance property ## Files Changed - `src/ServiceControl.Config/UI/AdvancedOptions/ServiceControlAdvancedViewModel.cs` ## Testing - RavenDB Management Studio hyperlink now appears as an active blue link - Clicking the link properly opens the RavenDB Studio at `http://localhost:{port}/studio/index.html#databases` - Right-click context menu "Copy to Clipboard" functionality works correctly Fixes issue introduced in #5237
cquirosj
added a commit
that referenced
this pull request
Dec 24, 2025
# Fix RavenDB Management Studio link binding issue ## Summary This PR fixes a property name mismatch introduced in PR #5237 that caused the RavenDB Management Studio hyperlink to be grayed out and non-functional in the ServiceControl Management UI. ## Problem After merging PR #5237 "Point RavenDB Management Studio link to localhost", the RavenDB Management Studio link in the Advanced Options maintenance mode section became unresponsive. The link appeared grayed out and clicking it had no effect. ## Root Cause PR #5237 renamed the property from `StorageUrl` to `RavenDbStudioUrl` in `ServiceControlBaseService.cs`, but the corresponding ViewModel property in `ServiceControlAdvancedViewModel.cs` was incorrectly named `RavenStudioUrl` (missing "Db"). This property name mismatch caused the WPF data binding to fail. ## Solution - Fixed property name in `ServiceControlAdvancedViewModel.cs` from `RavenStudioUrl` to `RavenDbStudioUrl` - This ensures proper binding between the ViewModel and the underlying ServiceControlInstance property ## Files Changed - `src/ServiceControl.Config/UI/AdvancedOptions/ServiceControlAdvancedViewModel.cs` ## Testing - RavenDB Management Studio hyperlink now appears as an active blue link - Clicking the link properly opens the RavenDB Studio at `http://localhost:{port}/studio/index.html#databases` - Right-click context menu "Copy to Clipboard" functionality works correctly Fixes issue introduced in #5237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of
Ensure the SMCU hyperlink to Launch RavenDB Studio (while in maintenance mode) points to RavenDB Studio on localhost.