Skip to content

Conversation

@cquirosj
Copy link
Contributor

@cquirosj cquirosj commented Dec 18, 2025

Fix hostname field input blocking in ServiceControl Management Utility

Addresses part of #5190 to allow for dashes

Problem

The hostname fields in the ServiceControl Management Utility (SCMU) were blocking valid dash (-) characters from being typed, while allowing invalid characters like /[]|. This was caused by CheckBox controls intercepting keystrokes for nested TextBox controls in the add instance views.

Users reported that typing - would not work but typing any of /[]| does work. The only workaround was to paste the dash character from the clipboard.

Root Cause

The issue occurred because:

  1. TextBox controls for hostname input were nested inside CheckBox controls in the XAML layout
  2. WPF CheckBox controls intercept certain keystrokes (including dashes) for their nested content
  3. This prevented users from typing dashes directly into hostname fields, requiring copy/paste workarounds

Solution

Restructured the UI layout in the add instance views to separate CheckBox and Expander controls using a Grid-based horizontal layout.

Before:

<CheckBox IsChecked="{Binding InstallErrorInstance}">
    <Expander Header="ServiceControl">
        <!-- TextBox controls nested inside CheckBox -->
        <controls:FormTextBox Header="HOST NAME" Text="{Binding ErrorHostName}" />
    </Expander>
</CheckBox>
image

After:

<Grid>
    <Grid.ColumnDefinitions>
        <ColumnDefinition Width="Auto"/>
        <ColumnDefinition Width="*"/>
    </Grid.ColumnDefinitions>

    <CheckBox Grid.Column="0"
              IsChecked="{Binding InstallErrorInstance}"
              VerticalAlignment="Top"
              Margin="0,8,8,5"/>

    <Expander Grid.Column="1"
              Header="ServiceControl"
              IsEnabled="{Binding InstallErrorInstance}"
              Margin="0,5,0,5">
        <!-- TextBox controls no longer nested in CheckBox -->
        <StackPanel Visibility="{Binding InstallErrorInstance, Converter={StaticResource boolToVis}}">
            <controls:FormTextBox Header="HOST NAME" Text="{Binding ErrorHostName}" />
        </StackPanel>
    </Expander>
</Grid>
image

# Fix hostname field input blocking in ServiceControl Management Utility

**Fixes #5190**

## Problem

The hostname fields in the ServiceControl Management Utility (SCMU) were blocking valid dash (`-`) characters from being typed, while allowing invalid characters like `/[]|`. This was caused by CheckBox controls intercepting keystrokes for nested TextBox controls in the add instance views.

Users reported that typing `-` would not work but typing any of `/[]|` does work. The only workaround was to paste the dash character from the clipboard.

## Root Cause

The issue occurred because:
1. TextBox controls for hostname input were nested inside CheckBox controls in the XAML layout
2. WPF CheckBox controls intercept certain keystrokes (including dashes) for their nested content
3. This prevented users from typing dashes directly into hostname fields, requiring copy/paste workarounds

## Solution

Restructured the UI layout in the add instance views to separate CheckBox and Expander controls using a Grid-based horizontal layout.

### Before:
```xaml
<CheckBox IsChecked="{Binding InstallErrorInstance}">
    <Expander Header="ServiceControl">
        <!-- TextBox controls nested inside CheckBox -->
        <controls:FormTextBox Header="HOST NAME" Text="{Binding ErrorHostName}" />
    </Expander>
</CheckBox>
```

### After:
```xaml
<Grid>
    <Grid.ColumnDefinitions>
        <ColumnDefinition Width="Auto"/>
        <ColumnDefinition Width="*"/>
    </Grid.ColumnDefinitions>

    <CheckBox Grid.Column="0"
              IsChecked="{Binding InstallErrorInstance}"
              VerticalAlignment="Top"
              Margin="0,8,8,5"/>

    <Expander Grid.Column="1"
              Header="ServiceControl"
              IsEnabled="{Binding InstallErrorInstance}"
              Margin="0,5,0,5">
        <!-- TextBox controls no longer nested in CheckBox -->
        <StackPanel Visibility="{Binding InstallErrorInstance, Converter={StaticResource boolToVis}}">
            <controls:FormTextBox Header="HOST NAME" Text="{Binding ErrorHostName}" />
        </StackPanel>
    </Expander>
</Grid>
```
@cquirosj cquirosj marked this pull request as ready for review December 19, 2025 01:36
@cquirosj cquirosj merged commit 6231690 into master Dec 22, 2025
61 of 62 checks passed
@cquirosj cquirosj deleted the hostname-chars-5190-bug-fix branch December 22, 2025 15:49
@cquirosj cquirosj added this to the 6.8.1 milestone Dec 23, 2025
@cquirosj cquirosj added the Bug label Dec 23, 2025
cquirosj pushed a commit that referenced this pull request Dec 23, 2025
# Fix hostname validation in SCMU

## Summary

This PR completes the fix for issue #5190 by adding proper hostname validation to ServiceControl.Config. While PR #5238 partially addressed the issue by allowing dashes in hostnames, it didn't implement comprehensive hostname validation, leaving users able to enter invalid hostnames that would cause configuration issues.

## Background

**Original Issue**: #5190 reported that ServiceControl.Config was not properly validating hostname fields, allowing users to enter invalid values that would cause runtime failures.

**Previous Fix**: PR #5238 addressed part of the problem by allowing dashes in hostnames, but the validation was still incomplete and didn't prevent other invalid hostname formats.

**This Fix**: Implements comprehensive RFC-compliant hostname validation using .NET's built-in `Uri.CheckHostName()` method.

## Changes Made

### New Validation Infrastructure
- Added `ValidHostname<T>()` extension method to `Validations.cs` using `Uri.CheckHostName(hostname) == UriHostNameType.Dns`
- Added `MSG_INVALID_HOSTNAME` constant for consistent error messaging

### Applied Hostname Validation to All Relevant Screens
- **Monitoring instances**: `SharedMonitoringEditorViewModelValidator` (Add/Edit)
- **ServiceControl Error instances**: `ServiceControlEditViewModelValidator`, `ServiceControlAddViewModelValidator`
- **ServiceControl Audit instances**: `ServiceControlAuditEditViewModelValidator`, `ServiceControlAddViewModelValidator`
- **Upgrade scenarios**: `AddNewAuditInstanceViewModelValidator`

## Validation Behavior

The new validation accepts:
- ✅ Valid DNS hostnames (server01, myhost.domain.com)
- ✅ localhost
- ✅ Hostnames with dashes (server-01, my-host.domain.com) - *previously fixed by PR #5238*
cquirosj pushed a commit that referenced this pull request Dec 23, 2025
# Fix hostname validation in SCMU

## Summary

This PR completes the fix for issue #5190 by adding proper hostname validation to ServiceControl.Config. While PR #5238 partially addressed the issue by allowing dashes in hostnames, it didn't implement comprehensive hostname validation, leaving users able to enter invalid hostnames that would cause configuration issues.

## Background

**Original Issue**: #5190 reported that ServiceControl.Config was not properly validating hostname fields, allowing users to enter invalid values that would cause runtime failures.

**Previous Fix**: PR #5238 addressed part of the problem by allowing dashes in hostnames, but the validation was still incomplete and didn't prevent other invalid hostname formats.

**This Fix**: Implements comprehensive RFC-compliant hostname validation using .NET's built-in `Uri.CheckHostName()` method.

## Validation Behavior

The new validation accepts:
- ✅ Valid DNS hostnames (server01, myhost.domain.com)
- ✅ localhost
- ✅ Hostnames with dashes (server-01, my-host.domain.com) - *previously fixed by PR #5238*
cquirosj added a commit that referenced this pull request Dec 24, 2025
# Fix hostname validation in SCMU

## Summary

This PR completes the fix for issue #5190 by adding proper hostname validation to ServiceControl.Config. While PR #5238 partially addressed the issue by allowing dashes in hostnames, it didn't implement comprehensive hostname validation, leaving users able to enter invalid hostnames that would cause configuration issues.

## Background

**Original Issue**: #5190 reported that ServiceControl.Config was not properly validating hostname fields, allowing users to enter invalid values that would cause runtime failures.

**Previous Fix**: PR #5238 addressed part of the problem by allowing dashes in hostnames, but the validation was still incomplete and didn't prevent other invalid hostname formats.

**This Fix**: Implements comprehensive RFC-compliant hostname validation using .NET's built-in `Uri.CheckHostName()` method.

## Validation Behavior

The new validation accepts:
- ✅ Valid DNS hostnames (server01, myhost.domain.com)
- ✅ localhost
- ✅ Hostnames with dashes (server-01, my-host.domain.com) - *previously fixed by PR #5238*

* test case for IPV6

* fixing broken implementation for ips

* adding missing test cases

* Update src/ServiceControl.Config.Tests/Validation/EditAuditInstanceValidationTests.cs


Co-authored-by: Nick Gallegos <nick.gallegos@particular.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants