Aftershock parsing#1438
Open
ImmotephSimon wants to merge 4 commits intoPathOfBuildingCommunity:devfrom
Open
Conversation
…OfBuilding-PoE2 into aftershock merge upstream dev
add special case for line with comma add aftershock to TotalDPS
LocalIdentity
requested changes
Sep 24, 2025
rework calcOffence to use DPS multiplier (reliant on attack time) add support for unique: Hrimnor's Hymn add support for Aftershock III
Contributor
Author
|
Regarding Missing Mods / Supports
Added all your suggestions, moved the offenceCalc code below output.Speed, as it relies on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Some more aftershock mods are now properly parsed, under the assumption that "you use yourself" currently means no totems, no triggers, and no traps (which are coming eventually).
Aftershocks now affect TotalDPS.
Aftershock Chance is shown with Crit Chance.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Maxroll
Before screenshot:
Red text.
After screenshot: