Skip to content

Fix low life defence mods not applying sometimes when using Starkonja's, Rise of the Pheonix and Coward Legacy#1704

Merged
LocalIdentity merged 4 commits intoPathOfBuildingCommunity:devfrom
NamNgHH:test2
Feb 18, 2026
Merged

Fix low life defence mods not applying sometimes when using Starkonja's, Rise of the Pheonix and Coward Legacy#1704
LocalIdentity merged 4 commits intoPathOfBuildingCommunity:devfrom
NamNgHH:test2

Conversation

@NamNgHH
Copy link
Contributor

@NamNgHH NamNgHH commented Jan 3, 2026

Fixes # 1474.

Description of the problem being solved:

The issue was to fix the Coward's Legacy belt lowlife modifiers not working correctly. This was wrong since it worked correctly, verified by using the Pain Atunement note that 75% Lowlife is accounted correctly with Beidat's Hand. So the thing that doesn't work is the defense's calculation of items like Starkonja's Head or Rise of the Phoenix. So I solved the problem by changing calcs.defence functions.

Steps taken to verify a working solution:

  • Before the changes, the build is equipped with Starkonja's Head, Rise of Phoenix, and the evasion rating and fire resistance don't change when Beidat's Hand is taken, and having Coward's Legacy equipped.
  • Currently, if I take out Coward's Legacy, the lowlife effect of Starkonja's and Rise of the Phoenix doesn't affect my character
  • If I unallocate Beidat's Hand, the lowlife effect will also stop working since you are not a lowlife anymore.

Link to a build that showcases this PR:

https://pobb.in/R8tUNGCcbxCR

Before screenshot:

image image

After screenshot:

image image

Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the proper fix looks something like this: PathOfBuildingCommunity/PathOfBuilding#9351

That PR is for PoB1, and all this code was changed in #79, but we may just want to calculate these values earlier totally. This may allow us to replace the lower calls to doActorLifeManaSpirit. Doesn't seem to make much sense to call it so many times.

I'm trying to keep parity with the ordering of calculations, since we've divined them slowly over the years and moving things around in the Calc files causes frequent bugs if we get the ordering wrong. I think the way you have it in this PR would break any calculation like https://www.poewiki.net/wiki/Crimson_Power if they added it to PoE2

@NamNgHH
Copy link
Contributor Author

NamNgHH commented Jan 15, 2026

The mentioned method in the PoB1 issue fixed the bug, so I reverted my original changes and put in the same fix.

@LocalIdentity LocalIdentity added bug: behaviour Behavioral differences pob1 Should also be merged into PoB1 Repo and removed pob1 Should also be merged into PoB1 Repo labels Feb 18, 2026
@LocalIdentity LocalIdentity changed the title Fixed for #1474 Updating CalcDefense for it to consider items like Starkonja's, Rise of the Pheonix when is use with a different low life modifies items like Coward Legacy. Fix low life defence mods not applying sometimes when using Starkonja's, Rise of the Pheonix and Coward Legacy Feb 18, 2026
@LocalIdentity LocalIdentity merged commit 381f2a3 into PathOfBuildingCommunity:dev Feb 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments