Add compareJewelsOfSameType option for ItemsTab#9466
Add compareJewelsOfSameType option for ItemsTab#9466roychl666 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Compare only jewels of the same type when the option is set to true. Maintain existing behavior by defaulting the option to false.
|
I feel like this PR would cause more issues than it would solve. Many people never look in the options menu for something like this and would wonder why their jewels are suddenly no longer comparing to each other. |
|
Thanks for the feedback. To clarify, the option is disabled by default, so it shouldn't change the behavior unless enabled explicitly. For context, I’ve been looking at issues with 'good first issues' label and found #6275 resonate with my own use case. |
Compare only jewels of the same type when the option is set to true. Maintain existing behavior by defaulting the option to false.
This PR picks up the work started by @michelrtm in #6314. I've updated it to work with the tip of tree.
Fixes #6275.
Description of the problem being solved:
Currently, jewels (e.g., Abyss, Crimson, Cobalt, Viridian) are compared against all occupied jewel slots, including incompatible types like Cluster Jewels, which creates irrelevant data. This change introduces a toggle to ensure jewels are only compared against slots containing the same jewel type.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/6z027yW7pPix
Before screenshot:
With option default disabled.
After screenshot:
Enable the option.
