test: add fuzz tests for msb and sqrt

[marmitar]

Tests for mathematical properties of some functions in Common.sol. The implementation relies on the properties below.

For msb():

$$ x = 0 \implies \text{msb}(x) = 0 $$ $$ x > 0 \implies x \gg \text{msb}(x) = 1 $$

For sqrt():

$$ \left\lfloor\sqrt{x}\right\rfloor \leq \sqrt{x} < \left\lfloor\sqrt{x}\right\rfloor + 1 $$ $$ \left\lfloor\sqrt{x}\right\rfloor^2 \leq x < \left(\left\lfloor\sqrt{x}\right\rfloor + 1\right)^2 $$

[marmitar]

Hi, @PaulRBerg. Any chance I get a review on this one?

[PaulRBerg]

Hi @marmitar, I'm so sorry for dropping the ball here. You have my word that by Saturday, this PR and the other will be both reviewed. Thank you.

[PaulRBerg]

left some feedback below and pushed directly to your branch

will merge now to speed up the review process; if you have any further feedback feel free to open another PR @marmitar :)

Thanks again for your contribution!

[PaulRBerg]

would be good to use more specific test descriptions here

[PaulRBerg]

Incorrect test contract name

[PaulRBerg]

I''ll move this to another text function and use bound:

For broad checks, such as ensuring a uint256 falls within a certain range, you can bound your input with the modulo operator or Forge Standard's bound method.