-
Notifications
You must be signed in to change notification settings - Fork 15
Feature/visualize wc #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature/visualize wc #129
Conversation
| G_value (ndarray): the value of the Gram matrix G that the solver found. | ||
| F_value (ndarray): the value of the vector of :class:`Expression`s F that the solver found. | ||
| trim_dim (bool): trims the apperent useless dimensions of the found worst-case function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo on "apperent"
| # leading to different dual values. The ones we store here provide the proof of the obtained guarantee. | ||
| self.residual = wrapper.assign_dual_values() | ||
| G_value, F_value = wrapper.get_primal_variables() | ||
| nb_eigenvalues = G_value.shape[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand what this variable should contain. Given the attribute it is later stored in, I thought nb_eigenvalues should contain the rank of G_value (excluding the null eigenvalues). Did I miss something?
| else: | ||
| toggled_dimensions = Point.counter | ||
|
|
||
| return self.eval()[:toggled_dimensions] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since toggled_dimensions can be handily fixed, this can modify the inner product values. Shall we consider that the user is responsible for doing the right thing? Or should we enforce toggled_dimensions to be automatically fixed?
| """ | ||
| def __init__(self, list_of_triplets, mu, L, d, options='lowest'): | ||
| self.x_list, self.g_list, self.f_list = list_of_triplets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a list of triplets? Or a triplet of list that you are manipulating here?
| import cvxpy as cp | ||
| import numpy as np | ||
|
|
||
| class Interpolator(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a more specific name would be appropriate, given the covered classes.
No description provided.