Skip to content

Conversation

@AdrienTaylor
Copy link
Collaborator

No description provided.

G_value (ndarray): the value of the Gram matrix G that the solver found.
F_value (ndarray): the value of the vector of :class:`Expression`s F that the solver found.
trim_dim (bool): trims the apperent useless dimensions of the found worst-case function
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo on "apperent"

# leading to different dual values. The ones we store here provide the proof of the obtained guarantee.
self.residual = wrapper.assign_dual_values()
G_value, F_value = wrapper.get_primal_variables()
nb_eigenvalues = G_value.shape[0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand what this variable should contain. Given the attribute it is later stored in, I thought nb_eigenvalues should contain the rank of G_value (excluding the null eigenvalues). Did I miss something?

else:
toggled_dimensions = Point.counter

return self.eval()[:toggled_dimensions]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since toggled_dimensions can be handily fixed, this can modify the inner product values. Shall we consider that the user is responsible for doing the right thing? Or should we enforce toggled_dimensions to be automatically fixed?

"""
def __init__(self, list_of_triplets, mu, L, d, options='lowest'):
self.x_list, self.g_list, self.f_list = list_of_triplets
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a list of triplets? Or a triplet of list that you are manipulating here?

import cvxpy as cp
import numpy as np

class Interpolator(object):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a more specific name would be appropriate, given the covered classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants