Conversation
|
There is no release from MySQL yet, not sure if we should wait or not support it for now. |
|
Hi @SebastianStehle I was already working on it but you were faster :) I also changed to use Package Versioning but I'll do it later |
|
I see you already found the issue on the Pomelo repository, let's wait a few days more to finish this PR ;) |
|
@SebastianStehle I hope I did not mess up your pull request too much ;) I was not patient enough to wait for Pomelo to release their net10 package. What do you think ? |
There was a problem hiding this comment.
Pull request overview
Updates the repository to add .NET 10 targeting and CI support, while conditionally excluding MySql where dependencies aren’t available.
Changes:
- Add
net10.0to multi-targeting and update EF Core provider references accordingly. - Introduce
MysqlSupportedgating and#if MYSQL_SUPPORTEDguards to exclude MySql-specific code paths for net10. - Replace the
.slnwith.slnxsolutions and update GitHub Actions workflows to use them.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsBase.cs | Updates SmartEnum usage after renaming the static instance. |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs | Adjusts MySql options reference and adds a preprocessor guard around a test branch. |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj | Adds net10 NetTopologySuite refs and conditional exclusion of MySql code/project reference. |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestSmartEnum.cs | Renames TestSmartEnum.Value to TestSmartEnum.Test. |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/Program.cs | Conditionally includes MySql comparator based on MYSQL_SUPPORTED. |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj | Adds net10 comparator dependencies and conditional MySql exclusion/project reference. |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.cs | Wraps MySql raw-insert path in #if MYSQL_SUPPORTED. |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.RawInsert.cs | Wraps MySqlConnector import + raw-insert implementation in #if MYSQL_SUPPORTED. |
| tests/Directory.Build.props | Removes test-level build props in favor of repo-root props. |
| src/PhenX.EntityFrameworkCore.BulkInsert/PhenX.EntityFrameworkCore.BulkInsert.csproj | Adds EF Core Relational reference for net10. |
| src/PhenX.EntityFrameworkCore.BulkInsert.Sqlite/PhenX.EntityFrameworkCore.BulkInsert.Sqlite.csproj | Adds EF Core Sqlite reference for net10. |
| src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/PhenX.EntityFrameworkCore.BulkInsert.SqlServer.csproj | Adds EF Core SqlServer reference for net10. |
| src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql.csproj | Adds Npgsql EF Core reference for net10. |
| src/PhenX.EntityFrameworkCore.BulkInsert.Oracle/PhenX.EntityFrameworkCore.BulkInsert.Oracle.csproj | Adds Oracle EF Core reference for net10. |
| src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj | Pins MySql project TFMs to net8/net9 with notes about net10 support. |
| src/Directory.Build.props | Changes src-level props to import the repo-root props and bumps JetBrains.Annotations. |
| PhenX.EntityFrameworkCore.BulkInsert.slnx | Adds new XML solution format including all projects. |
| PhenX.EntityFrameworkCore.BulkInsert.sln | Removes the legacy Visual Studio .sln. |
| PhenX.EntityFrameworkCore.BulkInsert.Net10.slnx | Adds net10-focused solution excluding MySql. |
| Directory.Build.props | Adds repo-root build props (TFMs + MySql gating). |
| .github/workflows/release.yml | Updates CI to test net8/net9/net10 and pack via .slnx. |
| .github/workflows/dotnet-test.yml | Updates CI matrix to include net10 and builds/tests via .slnx. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj
Show resolved
Hide resolved
tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.cs
Outdated
Show resolved
Hide resolved
tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs
Show resolved
Hide resolved
|
Understandable. Lets go. I have to wait for pamelo anyway because I have a dependency in my app too :( |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
# Conflicts: # tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj
No description provided.