Skip to content

Conversation

@Sublimis
Copy link

@Sublimis Sublimis commented Nov 9, 2020

Use double-s instead of float-s to minimize rounding errors that can lead to axis labels saying e.g. "9999.999" instead of "10000". There's really no excuse for using float-s here, and probably throughout much of the rest of the code, too. Maybe this remark could be taken into consideration to prevent similar problems in the future.

Use double-s instead of float-s to minimize rounding errors that can lead to axis labels saying e.g. "9999.999" instead of "10000". There's really no excuse for using float-s here, and probably throughout much of the rest of the code, too.
@Paget96
Copy link

Paget96 commented Dec 11, 2022

I really like this library and using it in my apps, I would like to call people to continue with this awesome thing. I have forked the repo and started working on it! So I am ready as well to accept pull requests, I'll notify other people from here as well!
Would be more than happy if we continue with this awesome project.

Code is full kotlin now!

Make your pull requests here:
https://github.com/Paget96/MPAndroidChart

@hannesa2
Copy link
Contributor

hannesa2 commented Jan 2, 2026

@Sublimis
I did a test of this AppDevNext#637 and there you'll see what happens as screenshots.
Do you have maybe better show cases ?

@Sublimis
Copy link
Author

Sublimis commented Jan 2, 2026

@hannesa2
Only found this one old screenshot that shows incorrect rounding on the horizontal axis (1.99k, 3.99k, etc), before this PR fix was applied. Maybe this helps.

image

@hannesa2
Copy link
Contributor

hannesa2 commented Jan 4, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants