-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Fedex - new components #19385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fedex - new components #19385
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughAdds four FedEx tracking actions and corresponding tracking methods/propDefinitions in the FedEx app, plus minor version bumps for the component and two actions. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (6)
components/fedex/actions/track-by-reference/track-by-reference.mjs(1 hunks)components/fedex/actions/track-by-tcn/track-by-tcn.mjs(1 hunks)components/fedex/actions/track-by-tracking-number/track-by-tracking-number.mjs(1 hunks)components/fedex/actions/track-multi-piece-shipment/track-multi-piece-shipment.mjs(1 hunks)components/fedex/fedex.app.mjs(2 hunks)components/fedex/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/fedex/package.json
🧬 Code graph analysis (3)
components/fedex/actions/track-by-tcn/track-by-tcn.mjs (3)
components/fedex/actions/track-by-reference/track-by-reference.mjs (1)
response(63-76)components/fedex/actions/track-by-tracking-number/track-by-tracking-number.mjs (1)
response(30-42)components/fedex/actions/track-multi-piece-shipment/track-multi-piece-shipment.mjs (1)
response(40-51)
components/fedex/actions/track-by-tracking-number/track-by-tracking-number.mjs (3)
components/fedex/actions/track-by-reference/track-by-reference.mjs (1)
response(63-76)components/fedex/actions/track-by-tcn/track-by-tcn.mjs (1)
response(41-51)components/fedex/actions/track-multi-piece-shipment/track-multi-piece-shipment.mjs (1)
response(40-51)
components/fedex/actions/track-by-reference/track-by-reference.mjs (3)
components/fedex/actions/track-by-tcn/track-by-tcn.mjs (1)
response(41-51)components/fedex/actions/track-by-tracking-number/track-by-tracking-number.mjs (1)
response(30-42)components/fedex/actions/track-multi-piece-shipment/track-multi-piece-shipment.mjs (1)
response(40-51)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Verify TypeScript components
- GitHub Check: Publish TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (5)
components/fedex/package.json (1)
3-3: Version bump is consistent with new functionalityUpdating
versionto0.2.0aligns with the addition of new tracking actions; nothing else in this manifest raises concerns.components/fedex/actions/track-by-tracking-number/track-by-tracking-number.mjs (1)
1-45: Action wiring and payload look goodProps, request payload (
trackingInfowithtrackingNumberInfo), and summary usage ofthis.trackingNumberare consistent and match the newtrackByTrackingNumberapp method.components/fedex/actions/track-multi-piece-shipment/track-multi-piece-shipment.mjs (1)
1-54: Multi‑piece shipment action is consistent and coherentThe props,
associatedTypeoptions, request payload, and summary all line up with thetrackMultiplePieceShipmenthelper; no issues found.components/fedex/fedex.app.mjs (1)
181-202: New tracking propDefinitions and helper methods are wired correctlyThe added tracking-related props are simple and reusable, and the four new helper methods correctly delegate to
_makeRequestusing the expected tracking endpoints and POST semantics, matching how the new actions call them.Also applies to: 233-260
components/fedex/actions/track-by-tcn/track-by-tcn.mjs (1)
1-55: TCN tracking action matches app helper and propsThe
tcnInfopayload, date props viapropDefinition, and$summaryusingthis.valueall look consistent withtrackByTrackingControlNumber.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
components/fedex/actions/create-shipment/create-shipment.mjs(1 hunks)components/fedex/actions/track-by-reference/track-by-reference.mjs(1 hunks)components/fedex/actions/validate-shipment/validate-shipment.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-07-04T18:11:59.822Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Applied to files:
components/fedex/actions/track-by-reference/track-by-reference.mjs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Lint Code Base
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: pnpm publish
🔇 Additional comments (3)
components/fedex/actions/validate-shipment/validate-shipment.mjs (1)
7-7: Version bump for validate-shipment looks consistent
version: "0.0.3"aligns with the other updated FedEx actions and the package version bump; no further changes needed here.components/fedex/actions/create-shipment/create-shipment.mjs (1)
7-7: Version bump for create-shipment is appropriateSetting
version: "0.0.3"keeps this action in sync with the other FedEx actions and the package metadata; no issues spotted.components/fedex/actions/track-by-reference/track-by-reference.mjs (1)
59-78: run() flow and $summary look solidThe
runmethod’s guard:if (!this.accountNumber && (!this.destinationPostalCode || !this.destinationCountryCode)) { throw new ConfigurationError("Either `accountNumber` or `destinationPostalCode` and `destinationCountryCode` must be provided."); }correctly enforces the documented “account vs destination” requirement and fails fast with a clear configuration error.
The summary export:
$.export("$summary", `Tracking information for ${this.value} retrieved successfully`);uses the defined
valueprop instead of a non‑existent tracking number field and provides a clear, user‑friendly message. Based on learnings, this follows the preferred$summarypattern.
GTFalcao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolves #19335
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.