Update dependencies and Python version by Grimpy101 · Pull Request #20 · Podnapisi-NET/flask-phpbb3

Grimpy101 · 2025-12-27T21:06:18Z

Changes and additions:

Update to Python 3.14 (although back-compatibility to Python 3.8 has been tested as well)
- Moved from comment-based type annotation to Python 3 type hints
- Changed some parts with unicode type to bytes (Pyscopg2Backend)
- Removed absolute_import
- Adjusted tests (list comparison was changed to set comparison, built-in testing dependency is used)
- setup.py and setup.cfg were removed in favour of pyproject.toml
Update dependencies (Flask, psycopg2)
- Bumped Flask version
- Switched from deprecated flask._app_ctx_stack to flask.g (PhpBB3)
- Moved from werkzeug.contrib.cache to cachelib library
- In tests, set_cookie(...) function arguments were reordered, and server address was specified in client config

Notes:

.travis.yml was updated, but the new configuration was not tested
All files were structured in accordance with flake8 and mypy configuration

…lask.g

MasterMind2k

Awesome!

A few things to consider:

Write commits as a story, concentrate to write_reason of change_ into commit message (answer the question why). The answer to question What is answered in change itsef
Be more graceus with dependencies for packages, limit the lowest allowed version of flask and to next major release (hoping flask follows semver)

And some additional wishes:

switch from flake8 to ruff
introduce black formatter
Introduce uv for handling dependencies
Go through coerage report and increase test coverage

Thank you for help! Very much appreciated.

MasterMind2k · 2025-12-28T15:36:58Z

requirements.txt

-Flask>=0.10
-typing
+psycopg2>=2.9.11
+Flask>=3.1.2


Dependencies should be more "inclusive" regarding dependencies. Is latestflask really needed?

Sure, we can probably lower the Flask version to 2.3.0 (this is where support for Python 3.7 was dropped and most breaking changes were introduced). For psycopg2, version 2.9.10 would likely suffice (that's where the support for Python 3.7 was dropped as well), although I need to check if it is compatible with Python 3.14 ...

We can make intermediate version to have 3.8 version supported.

Afaik, only podnapisi.net uses this library :) .

MasterMind2k · 2025-12-28T15:40:02Z

flask_phpbb3/backends/psycopg2.py

 from __future__ import absolute_import

 import json
-import typing


Please use module imports.

In python, non-modules (function, classes, etc.) get new reference and are harder to mock. I understad, typing will never be mocked, but it has to be imported in same way as everything else.

Noted 👍
I will correct it.

MasterMind2k · 2025-12-28T15:40:48Z

flask_phpbb3/backends/psycopg2.py

        """
        # Setters for custom fields
-        custom_fields = self._config.get('CUSTOM_USER_FIELDS', [])
+        custom_fields: List[Any] = self._config.get('CUSTOM_USER_FIELDS', [])


We can safely assume this is list of strings.

MasterMind2k · 2025-12-28T15:43:06Z

flask_phpbb3/extension.py

-            return backend
-        raise AttributeError('No context available')
+        backend: Optional[flask_phpbb3.backends.base.BaseBackend] =\
+            flask.g.get('phpbb3_backend', None)


Could you describe why this change?

In Flask 2.3, flask._app_ctx_stack was removed. The preferred way, as I understand it, is to use Flask's g object to store global data (as noted in this GitHub post).

Great explanation! Something that has place in git commit.

MasterMind2k · 2025-12-28T15:48:11Z

flask_phpbb3/sessions.py

-class PhpBB3Session(dict, flask.sessions.SessionMixin):
-    def __init__(self):
-        # type: () -> None
+class PhpBB3Session(Dict[str, Any], flask.sessions.SessionMixin):


Why inherit from typing.Dict?

Fair, I can change it back, I just wanted more granular typing (dict with string keys in this case). But as far as I know, typing.Dict behaves as dict when inherited.

MasterMind2k · 2025-12-28T15:51:09Z

pyproject.toml

Very nice!!!

MasterMind2k · 2025-12-28T15:51:37Z

.travis.yml

-    else
-      pip install -r requirements/dev-3.txt
-    fi
+    pip install -r requirements/dev-3.txt


Could you also prepare environment management with uv?

I will look into it :)

MasterMind2k · 2025-12-28T15:52:17Z

flask_phpbb3/backends/base.py

 ACL_OPTIONS_CACHE_TTL: int = 3600 * 1


-class BaseBackend:


That's a big commit change for a python 3.8 compatibility :) . It makes review harder.

Sorry, I'll try to keep these to a minimum and explain them better. If I recall correctly, BaseBackend was only moved below UserAcl so that the type hints in UserAcl could recognize it.

No worries, you are doing great! Maybe give a Tidy First? book a try.

Also, this is a great oportuity to try out git rebase -i and master "writing commits". Something that helped me was https://cbea.ms/git-commit/

Great, I will have a look at the book! I tried rebasing, so now I have a bit of an idea how to modify commits :)

…e imports

…n in-built types

Grimpy101 · 2025-12-28T18:43:12Z

I have tried to address all feedback, and I've added Black formatter and ruff, and introduced uv for package management. Maybe I'll also extend test coverage when I have time.

Grimpy101 added 17 commits December 26, 2025 15:55

Update dependencies

195036d

Update BaseBackend class

144b90b

Update UserAcl

4f2dc48

Update UserAcl

71249f7

Update Python version in mypy config

2e22b85

Modify BaseBackend.execute method to improve typing

4a98464

Update Psycopg2Backend

0dd3ff0

Remove absolute_import

fb2e7b7

Bump Python version in configs

fb9a1f4

Update imports in psycopg2.py, extensions.py, and sessions.py

68ef44f

Update PhpBB3, reassign phpbb3_backend from flask._app_ctx_stack to f…

2a3e0d8

…lask.g

Update sessions.py, add error handling in extension.py

d47b447

Add comments

2c571ed

Fixing tests WIP

39a6f90

Update requirements, adjust tests for this Flask version

6980284

Format tests

a1c214e

Update package building

90be040

MasterMind2k requested changes Dec 28, 2025

View reviewed changes

Grimpy101 force-pushed the python-update branch 2 times, most recently from 74a0ab1 to 919eebe Compare December 28, 2025 18:23

Grimpy101 added 4 commits December 28, 2025 19:24

Switch ordering of classes to make types Python 3.8 compatible, updat…

84ff723

…e imports

Switch to uv package management

6ff847b

Unify module imports

3399d66

Specify definite typing based on context, change inharitance to pytho…

31818e0

…n in-built types

Grimpy101 force-pushed the python-update branch from 919eebe to 31818e0 Compare December 28, 2025 18:24

Format files with Black formatter

e7ecc93

Conversation

Grimpy101 commented Dec 27, 2025

Uh oh!

MasterMind2k left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MasterMind2k Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Grimpy101 commented Dec 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MasterMind2k Dec 28, 2025 •

edited

Loading